Repository navigation
Perf/scoreboard - #431
Merged
Merged
Perf/scoreboard#431
Conversation
- introduce PlayerNmsScoreboard class for packet-based sidebars - implement createPlayerScoreboard method in NmsProvider - add V1_21_11PlayerNmsScoreboardImpl and V26_1PlayerNmsScoreboardImpl for version-specific logic - enhance scoreboard operations with methods for updating title and lines
…s and title support - add viewer line functionality to the scoreboard - update player scoreboard creation to include title parameter - modify related classes and methods to support new features - update version to 3.46.0
… performance - refactor line update logic to minimize unnecessary score resets - implement pending content handling for efficient updates - enhance shared line drawing logic to prevent redundant updates
…nt and dynamic updates - add SidebarLine data class for managing individual sidebar lines - implement SidebarRegistry for handling sidebar instances and player events - create SurfSidebar interface for sidebar operations and viewer management - add SurfSidebarFactory for creating different types of sidebars - implement auto-updating and global sidebar capabilities - enhance scoreboard integration with sidebar components
…te methods - remove title parameter from createPlayerScoreboard method - adjust PlayerNmsScoreboard to handle title and lines updates internally - improve update method to handle line changes more efficiently
- introduce sharedLine and sharedLines methods for rendering lines to all viewers - enhance SidebarBuilder and SidebarBuilderImpl to support shared line rendering - update documentation to reflect new shared line capabilities
- introduce sharedTitle method to set a title rendered once per update - implement buildSharedTitle method for configuring shared title components - enhance SidebarTitle interface to support shared titles
…annotations - add @SuppressWarnings("deprecation") to CreateScoreboard, StartScoreboard, and StopScoreboard - mark several methods in scoreboard-extensions.kt as @deprecated with replacement suggestions - update SurfAutoUpdatablePlayerScoreboard and SurfAutoUpdatableScoreboard interfaces to indicate deprecation
twisti-dev
marked this pull request as ready for review
September 27, 2026 15:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.