Repository navigation
Fix output folder collision in geothermalExampleWellbore - #46
Open
FrancescaWatson wants to merge 1 commit into
Open
FrancescaWatson wants to merge 1 commit into
FrancescaWatson wants to merge 1 commit into
Conversation
With hashing disabled (the default), the wellbore and reference packed problems in geothermalExampleWellbore were stored in the same output folder. The reference run overwrote the wellbore results, and reading them back failed with "Unrecognized field name Wellbore". convertToReservoirWellboreModel was meant to rename the case with a '_wb' suffix, but used isfield, which is always false for TestCase objects. Also check isprop so TestCase instances are renamed, and give the two problems in the example explicit names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With hashing disabled (the default), the wellbore and reference packed problems in geothermalExampleWellbore were stored in the same output folder. The reference run overwrote the wellbore results, and reading them back failed with "Unrecognized field name Wellbore".
convertToReservoirWellboreModel was meant to rename the case with a '_wb' suffix, but used isfield, which is always false for TestCase objects. Also check isprop so TestCase instances are renamed, and give the two problems in the example explicit names.