Ship pack.mcmeta on Forge and NeoForge - #39
Merged
Conversation
Reported on Forge 1.20.1: the game stops on the loading-error screen rather
than starting. Forge turns every mod jar into a resource pack, and
ResourcePackLoader.findPacks does this:
var meta = Pack.readPackMetadata(info, supplier, version);
...
if (pack == null)
ModLoader.get().addWarning(new ModLoadingWarning(modinfo,
ModLoadingStage.ERROR, "fml.modloading.brokenresources", file));
readPackMetadata returns null when pack.mcmeta is absent, and Forge raises
that at ERROR, which is what halts loading. These jars have never carried
one, so this affects every Forge and NeoForge jar the build has published,
not only 1.20.1 — building a target only ever proved it compiled.
pack_format comes from a table keyed by Minecraft version. The number
decides a compatibility warning and nothing else, on a pack the player never
sees, since mod packs are merged into the hidden "Mod resources" entry — so
versions missing from the table fall back to the newest known value.
Fabric needs none of this and is untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S9bDcjZpEBbtCnt8daJigs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Forge 1.20.1: the game stops on the loading-error screen rather than starting. Forge turns every mod jar into a resource pack, and ResourcePackLoader.findPacks does this:
readPackMetadata returns null when pack.mcmeta is absent, and Forge raises that at ERROR, which is what halts loading. These jars have never carried one, so this affects every Forge and NeoForge jar the build has published, not only 1.20.1 — building a target only ever proved it compiled.
pack_format comes from a table keyed by Minecraft version. The number decides a compatibility warning and nothing else, on a pack the player never sees, since mod packs are merged into the hidden "Mod resources" entry — so versions missing from the table fall back to the newest known value.
Fabric needs none of this and is untouched.
Claude-Session: https://claude.ai/code/session_01S9bDcjZpEBbtCnt8daJigs