fix(googleai): escape raw newlines in stream response to prevent json decode error#298
Open
Phuocminh94 wants to merge 1 commit into
Open
fix(googleai): escape raw newlines in stream response to prevent json decode error#298Phuocminh94 wants to merge 1 commit into
Phuocminh94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the Gemini API, the streaming response contains raw, unescaped newlines within the
"text"field. This breaks the JSON structure during streaming, causingvim.json.decodeto throw a fatal runtime error:Expected object key string but found T_OBJ_END.Solution
This PR sanitizes the
lineby escaping raw newlines (\n) and carriage returns (\r) before feeding it into the decoder. Additionally, it wraps the decode process in apcallto ensure plugin stability even if the stream contains other unexpected formatting anomalies.Error Log