Remove deprecated EmberError and assign - #59
Merged
RobbieTheWagner merged 3 commits intoAug 20, 2024
Merged
Conversation
EmberErrorEmberError and assign
RobbieTheWagner
approved these changes
Aug 20, 2024
|
@RobbieTheWagner could you make a release with this fix? It's a blocker for ember v5 |
Owner
|
@dwickern yes, apologies for the delay! I need to update this addon in general and setup release-plan so we can easily do releases in the future. |
|
Thank you! ember-ajax is archived and ember-fetch removed all of its functionality in version 8. This addon seems like the easiest path forward. |
Owner
|
2.0.0 has been released, please let me know how it works for you! |
|
Works great! I see now there's an RFC to deprecate ember-fetch. If that happens, maybe this addon could drop the ember-fetch dependency and wire up the test waiters directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
EmberError- https://deprecations.emberjs.com/id/deprecate-ember-errorassign- https://deprecations.emberjs.com/id/ember-polyfills-deprecate-assign