Skip to content

Remove deprecated EmberError and assign - #59

Merged
RobbieTheWagner merged 3 commits into
RobbieTheWagner:mainfrom
alyne:wozny1989/remove-deprecated-ember-error
Aug 20, 2024
Merged

Remove deprecated EmberError and assign#59
RobbieTheWagner merged 3 commits into
RobbieTheWagner:mainfrom
alyne:wozny1989/remove-deprecated-ember-error

Conversation

@wozny1989

@wozny1989 wozny1989 commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

@wozny1989 wozny1989 changed the title Remove deprecated EmberError Remove deprecated EmberError and assign Jul 9, 2024
@RobbieTheWagner RobbieTheWagner added the enhancement New feature or request label Aug 20, 2024
@RobbieTheWagner
RobbieTheWagner merged commit 194ebb5 into RobbieTheWagner:main Aug 20, 2024
@dwickern

Copy link
Copy Markdown

@RobbieTheWagner could you make a release with this fix? It's a blocker for ember v5

@RobbieTheWagner

Copy link
Copy Markdown
Owner

@dwickern yes, apologies for the delay! I need to update this addon in general and setup release-plan so we can easily do releases in the future.

@dwickern

Copy link
Copy Markdown

Thank you! ember-ajax is archived and ember-fetch removed all of its functionality in version 8. This addon seems like the easiest path forward.

@RobbieTheWagner

Copy link
Copy Markdown
Owner

2.0.0 has been released, please let me know how it works for you!

@dwickern

Copy link
Copy Markdown

Works great!

I see now there's an RFC to deprecate ember-fetch. If that happens, maybe this addon could drop the ember-fetch dependency and wire up the test waiters directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants