Repository navigation
fix(LockupClaimModal): wire onClaim lifecycle, high-gas confirmation,… - #984
Merged
Merged
Conversation
|
@Bigclavsfx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #937
Summary of Changes
LockupClaimModal.tsx:
Added onClaim?: (options: { autoClaim: boolean }) => Promise<LockupClaimResult | void> with pending, error, and confirmed states, synchronous double-submit protection (inFlightRef), and button disabled/loading state while pending.
Updated the high-gas path (gasEstimate >= 80) to show the warning on the first click and switch the action label to "Claim anyway" so a second confirmation proceeds with onClaim({ autoClaim }).
Added a Tab / Shift+Tab focus trap within the dialog and restored focus to the opener element when closing.
Rendered the returned transaction hash along with an external explorer link (explorerBaseUrl, defaulting to Stellar Expert) when available.
LockupClaimModal.test.tsx:
Added unit and regression tests covering single-invocation onClaim({ autoClaim }) per confirmed click, pending disabled state, transaction hash & explorer link rendering, rejection error handling and button re-enabling, two-step high-gas confirmation, Tab focus trapping, and focus restoration on close.