ci: CI only runs vite build, so the 235 vitest files, typecheck and lint never run on pull requests #961
Description
Summary
The only CI job runs npm ci and npm run build (vite build), which neither type-checks nor runs tests. The repo has 235 test files and a strict tsconfig.json, but regressions and type errors merge without anyone noticing. The coverage include list also references src/pages/DistributionDashboard.tsx, which does not exist.
Evidence
.github/workflows/ci.yml: steps arenpm ciandnpm run buildonlypackage.jsonscripts:"build": "vite build","test": "vitest run --coverage","lint": ..., and there is no typecheck scriptvite.config.tscoverage include lists'src/pages/DistributionDashboard.tsx'; onlysrc/pages/DistributionDashboard.types.tsexistsgit ls-files src | grep -c '\.test\.'gives 235
Scope
- Add a
typecheckscript (tsc --noEmit -p .) and fix any errors it reports, without// @ts-ignoreor looseningstrict - Add CI jobs for
npm run typecheck,npm run lintandnpm test, caching npm. Upload the coverage summary as an artifact. - Fix the coverage include list (remove or replace the missing file), and set a coverage threshold for the included critical files at the current measured level
- Quarantine any currently failing tests with a tracked list in the PR description rather than deleting them
Out of scope
- Writing new feature tests
- Changing the deploy pipeline
Acceptance criteria
- A PR with a type error, lint error or failing test fails CI
-
masterCI is green with all three jobs - The coverage config references only existing files
- No behaviour change outside the stated scope; CI stays green
Difficulty: high. Fixing existing type and test failures to get a green baseline can touch many files.
Not accepted: formatting-only changes, snapshot-only tests, disabling checks/type errors, unrelated refactors.
Activity
ravimahatonp commentedon Oct 18, 2026
Hello team,
I examined the issue "ci: CI only runs vite build, so the 235 vitest files, typecheck and lint never run on pull requests" in RevoraOrg/Revora-Frontend and would be glad to implement the required changes.
I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.
I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.
Thank you!
Alimzy commentedon Oct 19, 2026
@Alimzy has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Alimzy to this issue.
drips-wave commentedon Oct 19, 2026
Congratulations, @Alimzy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Alimzy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
ci: add typecheck, lint, and test jobs to CI workflow (#961) (#980)
grantfox-oss commentedon Oct 22, 2026
🎉 This issue has been marked as completed on GrantFox!
@Alimzy's PR #980 was approved and merged by @thlpkee20-wq.
🏆 @Alimzy: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (796 total points). Track your full progress on GrantFox.
👏 Great work, @Alimzy! Keep contributing to RevoraOrg.
drips-wave commentedon Oct 22, 2026
This issue has been completed by @Alimzy as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Alimzy: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.