Bound blob downloads with per-source timeouts#7185
Draft
ajpallares wants to merge 9 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Require the downloader on RemoteConfigBlobFetcher and drop its timeoutManager parameter, since the manager is a dependency of the downloader. Also drop the nil default on Backend's timeoutManager so callers pass it explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@RCGitBot please test |
…nto pallares/blob-source-timeouts Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Sources/Networking/RemoteConfigBlobDownloader.swift
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Blob downloads had no per-request timeout (
URLSession.shareddefaults to ~60s), so a slow or failing blob source stretchedgetOfferingslatency across the source-failover loop.Description
Stacks on #7179.