refactor(remote-config): use large item cache for blob store#7165
Draft
rickvdl wants to merge 2 commits into
Draft
refactor(remote-config): use large item cache for blob store#7165rickvdl wants to merge 2 commits into
rickvdl wants to merge 2 commits into
Conversation
Member
Author
|
@RCGitBot please test |
rickvdl
force-pushed
the
rickvdl/remote-config-blob-store-cache
branch
from
July 9, 2026 04:58
2977176 to
1d1c54f
Compare
Member
Author
|
@RCGitBot please test |
Member
Author
|
@RCGitBot please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from #7115 (comment)
Reuses the existing
LargeItemCacheabstraction overFileManagerinstead ofFileManagerdirectly in the remote config blob store.Unfortunately we can't fully offload the locking to the large item cache, since we still do synchronization across other state in the blob store (
knownRefs). So this isn't so much a 'clean up a lot of code' PR, but more 'lets use the existing abstraction for consistency'.