Enable workflows by default#3639
Draft
vegaro wants to merge 2 commits into
Draft
Conversation
With workflows always on, a non-legacy offering (paywall == null) is served through the /workflows endpoint instead of rendering its components locally. Wrap the offering's components in a single-screen workflow and stub the offerings/workflow fetch so the dialog renders the same sticky-footer content. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3639 +/- ##
==========================================
+ Coverage 80.27% 80.41% +0.13%
==========================================
Files 379 379
Lines 15557 15544 -13
Branches 2170 2168 -2
==========================================
+ Hits 12489 12499 +10
+ Misses 2203 2182 -21
+ Partials 865 863 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vegaro
added
pr:other
and removed
pr:feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Workflows are close to release, so the SDK should no longer require an internal DangerousSettings opt-in to enable multipage paywalls.
Description
Removes the
DangerousSettings.useWorkflowsAPI andforWorkflows()helper, always wires workflow cache/manager infrastructure, and routes non-legacy RevenueCatUI paywalls through workflows.Updates API snapshots, baseline profile entries, API tester coverage, and PaywallViewModel tests for the always-on workflow path.
Tested with focused Purchases and RevenueCatUI unit tests,
./scripts/api-dump.sh, and./scripts/api-check.sh.