Repository navigation
fix: resident sankey link colours, per-instance clip ids, dead code and stale docs - #97
Conversation
…docs - ResidentFlowsSankeyChart: pass the node-colour callback to SankeyLink as well, so each ribbon's gradient runs between its endpoints' colours instead of the library's positional fallback (as done for Outcomes in v1.6.5). - time-series-chart-shell: port upstream's per-instance clipPath id (#226), so two time-series charts on one page (compare mode) no longer share a grow clip. - Remove the unread `legacy` flag from nationalities and the unused `onSelect` prop from LanguageSwitcherProps. - Docs: correct the plural-rule description in the i18n README, the zh-cn and zh-tw convention headers (which contradicted their own strings), the Japan topology vertex count in ARCHITECTURE.md, and drop six duplicated resident-dataset banners from each non-English locale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EM2gyDaCzsEd8EHX6RxPyB
…cy flag - index.css: delete the 35 @Utility classes and the .floating-tooltip layer that nothing references (design-system audit C8, roadmap step 28). Usage was checked transitively, counting utilities pulled in by another's @apply. - residenceStatuses: drop the `legacy` field, which nothing reads; the row comments still record the 2015 merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EM2gyDaCzsEd8EHX6RxPyB
The 35 unused @Utility classes and .floating-tooltip are gone, so audit C8 and roadmap step 28 note that part as done. The rest of C8 (unused vendored primitives, unmounted charts, the .prettierrc tailwindConfig line) stands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EM2gyDaCzsEd8EHX6RxPyB
|
Policy events check (routine) This PR doesn't touch One gap worth evaluating: Everything else currently in the file looks consistent with its documented rules:
No blocking issues here — just flagging the residence-card entry for evaluation. Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com Generated by Claude Code |
This PR is stacked on #96, the comment audit, because it edits the locale headers that PR rewrote. Merge #96 first. GitHub then retargets this PR to
mainonce that branch is deleted; if the branch is kept, retarget it by hand.Summary
These fixes cover problems found during the comment audit.
Bugs
SankeyLinknow gets the samegetNodeColorcallback as the nodes. Before, the ribbons fell back to the library's positional colours and didn't match their end nodes. This is the same fix v1.6.5 made for the Outcomes sankey.time-series-chart-shell.tsx): ported upstream's per-instanceuseId()suffix (bklit #226) verbatim, so a re-vendor won't show a diff here. Two time-series charts on one page (compare mode) no longer share a grow clip path.Unused code
@utilityclasses and the.floating-tooltipblock fromindex.css, which nothing references. I checked this across the whole codebase, counting classes pulled in by another's@apply. This is design-system audit C8 and roadmap step 28.legacyflag fromnationalities.tsandresidenceStatuses.ts, and the unusedonSelectprop fromLanguageSwitcherProps.Docs
Intl.PluralRules.Verification
npm run lintandnpm run typecheckare clean, and all 804 tests pass.npm run buildsucceeds. The compiled CSS keeps every utility in use and none of the removed ones."v1.6.6" in the design-system docs is the expected next release number. Adjust it in both the repo copy and the artifact if the release is numbered differently.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EM2gyDaCzsEd8EHX6RxPyB
Generated by Claude Code