CherryPicked: [cnv-4.22] [Storage] De-quarantine libguestfs test and use data source#5221
Merged
rnetser merged 1 commit intoJun 17, 2026
Conversation
##### Short description: - De-quarantine `test_virtctl_libguestfs_with_specific_user`. - Replace HTTP import in favor of data source cloning. - Wait for the `libguestfs` container to be created before performing operations in it. ##### What this PR does / why we need it: Fixing a quarantined test by enhancing code and explicitly waiting for libguestfs to be created. Additionally, using data source instead of artifactory, to align with other tests. ##### Which issue(s) this PR fixes: CNV-47594 ##### Special notes for reviewer: None ##### jira-ticket: <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> https://redhat.atlassian.net/browse/CNV-47594 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Refactored test fixtures to use a generalized data-volume provisioning flow instead of a Cirros-specific helper. * Test setup now explicitly waits for data-volume readiness and for auxiliary pods to reach and exit RUNNING state. * Removed an expected-failure marker from a specific libguestfs test and simplified its fixture usage. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Emanuele Prella <eprella@redhat.com>
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
removed
the
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:passed
openshift-virtualization-qe-bot
requested review from
Ahmad-Hafe and
josemacassan
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5221 published |
Collaborator
|
/rebase |
|
Successfully rebased |
Contributor
|
/lgtm |
1 similar comment
Contributor
|
/lgtm |
Collaborator
|
/rebase |
Collaborator
|
/rebase |
|
Successfully rebased |
Collaborator
|
/retest security-committer-identity |
Collaborator
|
/lgtm |
Contributor
|
/approve |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5221. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #4556, PR owner: ema-aka-young