Skip to content

refactor(constants): split utilities/constants.py into submodule package #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dshchedr merged 9 commits into from
Jun 22, 2026
Merged

refactor(constants): split utilities/constants.py into submodule package #5188

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2fcd0de
refactor(constants): split utilities/constants.py into submodule package
vsibirsk Jun 10, 2026
492ac03
docs(constants): add module docstrings to all constants submodules
vsibirsk Jun 11, 2026
d4ce094
refactor(constants): move ADP_NAMESPACE into NamespacesNames class
vsibirsk Jun 11, 2026
fe7156a
drop dead constants
vsibirsk Jun 11, 2026
3f8fd27
refactor(constants): eliminate misc.py, regroup components.py
vsibirsk Jun 14, 2026
80180e8
refactor(constants): finalize module topology
vsibirsk Jun 14, 2026
7f431e7
update __init__.py docstring
vsibirsk Jun 16, 2026
9b40449
refactor(constants): expand NamespacesNames and use it in global_config
vsibirsk Jun 18, 2026
0793285
Merge branch 'main' into vk-refactor-constants
vsibirsk Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/global_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ALL_CNV_DEPLOYMENTS,
ALL_CNV_PODS,
ALL_HCO_RELATED_OBJECTS,
BREW_REGISTERY_SOURCE,
BREW_REGISTRY_SOURCE,
Comment thread
vsibirsk marked this conversation as resolved.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
vsibirsk marked this conversation as resolved.
Comment thread
vsibirsk marked this conversation as resolved.
CENTOS_STREAM9_PREFERENCE,
CENTOS_STREAM10_PREFERENCE,
CNV_OPERATORS,
Expand Down Expand Up @@ -69,11 +69,11 @@ def _get_default_storage_class(sc_list):

no_unprivileged_client = False
hco_cr_name = "kubevirt-hyperconverged"
hco_namespace = "openshift-cnv"
openshift_apiserver_namespace = "openshift-apiserver"
sriov_namespace = "openshift-sriov-network-operator"
marketplace_namespace = "openshift-marketplace"
machine_api_namespace = "openshift-machine-api"
hco_namespace = NamespacesNames.OPENSHIFT_CNV
openshift_apiserver_namespace = NamespacesNames.OPENSHIFT_APISERVER
sriov_namespace = NamespacesNames.OPENSHIFT_SRIOV_NETWORK_OPERATOR
marketplace_namespace = NamespacesNames.OPENSHIFT_MARKETPLACE
machine_api_namespace = NamespacesNames.MACHINE_API_NAMESPACE
golden_images_namespace = NamespacesNames.OPENSHIFT_VIRTUALIZATION_OS_IMAGES
hco_subscription = "" # TODO: remove constants/HCO_SUBSCRIPTION and use this instead.
disconnected_cluster = False
Expand All @@ -90,7 +90,7 @@ def _get_default_storage_class(sc_list):
cnv_registry_sources = {
"osbs": {
"cnv_subscription_source": HCO_CATALOG_SOURCE,
"source_map": BREW_REGISTERY_SOURCE,
"source_map": BREW_REGISTRY_SOURCE,
},
"hotfix": {
"cnv_subscription_source": HCO_CATALOG_SOURCE,
Expand All @@ -100,7 +100,7 @@ def _get_default_storage_class(sc_list):
},
"fbc": {
"cnv_subscription_source": HCO_CATALOG_SOURCE,
"source_map": BREW_REGISTERY_SOURCE,
"source_map": BREW_REGISTRY_SOURCE,
},
}

Expand Down
4 changes: 2 additions & 2 deletions tests/install_upgrade_operators/relationship_labels/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
VIRT_PLATFORM_AUTOPILOT,
VIRT_SYNCHRONIZATION_CONTROLLER,
VIRT_TEMPLATE_VALIDATOR,
VIRTCTL_CLIDOWNLOADS_KUBEVIRT_HYPERCONVERGED,
VIRTCTL_CLI_DOWNLOADS,
VIRTIO_WIN,
WINDOWS_BOOTSOURCE_PIPELINE,
)
Expand Down Expand Up @@ -331,7 +331,7 @@
VERSION_LABEL_KEY: None,
PART_OF_LABEL_KEY: HYPERCONVERGED_CLUSTER,
},
VIRTCTL_CLIDOWNLOADS_KUBEVIRT_HYPERCONVERGED: {
VIRTCTL_CLI_DOWNLOADS: {
MANAGED_BY_LABEL_KEY: HCO_OPERATOR,
COMPONENT_LABEL_KEY: COMPUTE_STR,
VERSION_LABEL_KEY: None,
Expand Down
Loading
Loading