Skip to content
Merged
30 changes: 17 additions & 13 deletions tests/storage/test_libguestfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
import pexpect
Comment thread
ema-aka-young marked this conversation as resolved.
Comment thread
ema-aka-young marked this conversation as resolved.
import pytest
from ocp_resources.pod import Pod
Comment thread
ema-aka-young marked this conversation as resolved.
from pytest_testconfig import config as py_config

from tests.storage.utils import create_cirros_dv
from utilities.constants import QUARANTINED, TIMEOUT_1MIN, UNPRIVILEGED_PASSWORD, UNPRIVILEGED_USER
from utilities.constants import TIMEOUT_1MIN, TIMEOUT_2MIN, UNPRIVILEGED_PASSWORD, UNPRIVILEGED_USER
from utilities.infra import login_with_user_password
from utilities.storage import create_dv, get_dv_size_from_datasource

pytestmark = pytest.mark.post_upgrade

Expand Down Expand Up @@ -40,13 +39,23 @@ def dv_created_by_specific_user(
request,
namespace,
client_for_test,
fedora_data_source_scope_module,
storage_class_name_scope_function,
):
yield from create_cirros_dv(
name=request.param["data_volume_name"],
namespace=namespace.name,
storage_class=py_config["default_storage_class"],
with create_dv(
dv_name=request.param["data_volume_name"],
storage_class=storage_class_name_scope_function,
Comment thread
jpeimer marked this conversation as resolved.
Outdated
client=client_for_test,
)
namespace=namespace.name,
source_ref={
"kind": fedora_data_source_scope_module.kind,
"name": fedora_data_source_scope_module.name,
"namespace": fedora_data_source_scope_module.namespace,
},
size=get_dv_size_from_datasource(data_source=fedora_data_source_scope_module),
) as dv:
dv.wait_for_dv_success(timeout=TIMEOUT_2MIN)
Comment thread
jpeimer marked this conversation as resolved.
Outdated
yield dv


@pytest.fixture()
Expand Down Expand Up @@ -86,13 +95,8 @@ def client_for_test(request, admin_client, unprivileged_client):
],
indirect=True,
)
@pytest.mark.xfail(
reason=f"{QUARANTINED}: Timeout exceeded. Tracked in CNV-62312",
run=False,
)
Comment thread
ema-aka-young marked this conversation as resolved.
@pytest.mark.s390x
def test_virtctl_libguestfs_with_specific_user(
client_for_test,
virtctl_libguestfs_by_user,
):
virtctl_libguestfs_by_user.sendline("libguestfs-test-tool")
Expand Down
23 changes: 0 additions & 23 deletions tests/storage/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,29 +400,6 @@ def _wait_for_sc_update():
yield edited_cdi_config


def create_cirros_dv(
namespace,
name,
storage_class,
client,
access_modes=None,
volume_mode=None,
dv_size=Images.Cirros.DEFAULT_DV_SIZE,
):
with create_dv(
dv_name=f"dv-{name}",
namespace=namespace,
url=get_http_image_url(image_directory=Images.Cirros.DIR, image_name=Images.Cirros.QCOW2_IMG),
size=dv_size,
storage_class=storage_class,
access_modes=access_modes,
volume_mode=volume_mode,
client=client,
) as dv:
dv.wait_for_dv_success()
yield dv


def check_snapshot_indication(snapshot, is_online):
snapshot_indications = snapshot.instance.status.indications
online = "Online"
Expand Down
Loading