chore: Moved the dev-tools plugin over to the monorepo#10155
Conversation
lizschwab
changed the title
github-actions
Bot
added
PR: chore
| reportFailure(error) { | ||
| const message = | ||
| error instanceof Error ? error.message : String(error); | ||
| error instanceof Error ? error.message : JSON.stringify(error); |
There was a problem hiding this comment.
I made this change while debugging but left it in because printing [Object object] doesn't help anyone
|
|
||
| test('are shown for the designated duration', function () { | ||
| const clock = sinon.useFakeTimers(); | ||
|
|
There was a problem hiding this comment.
This test started giving this error:
Can't install fake timers twice on the same global object.
I'm guessing a dependency somewhere got updated and this started accurately displaying this error, because the setup function already sets this.clock.
| "packages/plugins/theme-modern", | ||
| "packages/plugins/theme-tritanopia", | ||
| "packages/dev-tools", | ||
| "packages/docs" |
There was a problem hiding this comment.
I'm exploring using Nx to automatically handle build order for us. In the meantime, I'm using the workspaces order to determine the build order.
| "lint:fix": "npm run lint:fix --ws --if-present", | ||
| "build": "npm run package --workspace=blockly && npm run build --ws --if-present", | ||
| "lint:fix": "npm run lint:fix --ws --if-present", | ||
| "build": "npm run package --workspace=blockly && npm run build --ws --if-present", |
There was a problem hiding this comment.
Running package on blockly makes the themes happy when we go to build them.
There was a problem hiding this comment.
These appear to be present twice?
github-actions
Bot
added
PR: chore
| 'packages/blockly/typings/*', | ||
| 'packages/blockly/docs/*', | ||
| // Core Tests other than mocha unit tests | ||
| // Core Tests other than mocha unit tests |
There was a problem hiding this comment.
This and the next comment are duplicated
There was a problem hiding this comment.
Auto-merge decided to duplicate some things, looks like I missed these. Thanks for catching that!
| "lint:fix": "npm run lint:fix --ws --if-present", | ||
| "build": "npm run package --workspace=blockly && npm run build --ws --if-present", | ||
| "lint:fix": "npm run lint:fix --ws --if-present", | ||
| "build": "npm run package --workspace=blockly && npm run build --ws --if-present", |
There was a problem hiding this comment.
These appear to be present twice?
2 participants
The basics
The details
Resolves
Fixes #7763
Proposed Changes
Reason for Changes
This is part of the monorepo project.
Test Coverage
No new tests were added. I tested locally by doing the following:
Screenshot of change to dev-tools showing up in blockly advanced playground (changed name of
LogictoLogicA)Documentation
Documentation will be handled as part of a future task.
TODO