Reject deterministic failures before block inclusion - #3040
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: VULNERABLE VERY HIGH scrutiny: 33-day-old account with 0 public repositories; mitigated by repository write permission and substantive merged contributions. No Gittensor association found. Branch targets main. Findings
Prior-comment reconciliation
ConclusionThe runtime-affecting transaction-validation changes still leave 📜 Previous run (superseded)
# 🔍 AI Review — Auditor (domain review) has not yet run on this PR. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: VULNERABLE |
| return Ok(()); | ||
| }; | ||
|
|
||
| CheckColdkeySwap::<T>::check(who, call)?; |
There was a problem hiding this comment.
[CRITICAL] Bump the runtime spec version
This changes runtime transaction validation while runtime/src/lib.rs still declares spec_version: 442. During rollout, a node containing this native runtime may substitute it for the existing on-chain Wasm runtime with the same version, causing nodes to apply different validation behavior. Increment VERSION.spec_version for this runtime-affecting change.
|
🔄 AI review updated — Skeptic: VULNERABLE |
Value
This change prevents the two largest deterministic extrinsic failure classes before block inclusion.
CommittingWeightsTooFastAccountNotAllowedCommitAt the report’s measured run rate, this removes approximately 69% of landed failures and 3.6 GB/year of failed extrinsic and
ExtrinsicFailedevent payload—about 71% of the report’s total ~5 GB/year failure flow.Validation changes
set_commitmentWeight commits
commit_timelocked_weightscommit_timelocked_mechanism_weightscommit_crv3_mechanism_weightsprovidestag keyed by signer and subnet/mechanism so competing commits cannot coexist in the pool.Successful commitment behavior and the runtime transaction format remain unchanged.