Repository navigation
One source for artist moods: music_tags; artist_tags removed - #244
Merged
Merged
Conversation
#241 read moods per artist from each artist's metadata (artist_tags); #242 reads Plex's filter directories for artists, albums and tracks (music_tags) and feeds the Wrap-Up. Two stores of the same tags would drift, so the artist_tags job, its code in plex_players and the plex_artists columns' migration go (columns already added stay, unused). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
#241 read moods and styles per artist from each artist's own metadata (custodian job
artist_tags, columns onplex_artists). #242 then addedmusic_tags, which reads Plex's filter directories for artists, albums and tracks and feeds the Wrap-Up's moods.Two stores of the same tags would drift apart, so this removes the
artist_tagsjob, its code inservices/plex_players.py, and theplex_artistscolumn migration inlyrics.py. Columns already added to an existing lyrics.db stay and are unused. The player backfill (plex_players) is unchanged.Checks
python tests/run_all.pyis green (257/257)test_plex_playersnow checks that the custodian has noartist_tagsjob.🤖 Generated with Claude Code