Skip to content

⚡ Bolt: [performance improvement] Fast Counting for Debate Outcomes - #238

Merged
Randomname653 merged 1 commit into
mainfrom
bolt-fast-count-debate-outcome-13032803246625861068
Oct 25, 2026
Merged

Randomname653 merged 1 commit into
mainfrom
bolt-fast-count-debate-outcome-13032803246625861068

Conversation

@Randomname653

Copy link
Copy Markdown
Owner

💡 What

Refactored the user_turns function in src/services/debate_outcome.py to use func.count(M.id) and .scalar() instead of .count().

🎯 Why

In SQLAlchemy, appending .count() to a filtered model query generates an SQL subquery (e.g., SELECT count(*) FROM (SELECT ...)). Using func.count(M.id) generates a direct aggregation query (SELECT count(id) FROM ...), avoiding the subquery overhead and improving database execution speed.

📊 Impact

Measurable reduction in database query execution time for debate outcome resolution logs, particularly beneficial when evaluating high volumes of debates during custodian sprints.

🔬 Measurement

Run python tests/test_debate_outcome.py to ensure counting logic behaves exactly as before and properly attributes user turns. Check SQL query logs or SQLAlchemy echo outputs to observe the elimination of the subquery.


PR created automatically by Jules for task 13032803246625861068 started by @Randomname653

Replaced `.count()` on the `ConversationMessage` query with `db.query(func.count(M.id)).scalar()`. This avoids the unnecessary SQL subquery wrapper generated by `.count()`, improving database query efficiency when calculating user turns in debates.

Co-authored-by: Randomname653 <127677734+Randomname653@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Randomname653
Randomname653 merged commit 1c94db8 into main Oct 25, 2026
9 of 10 checks passed
@Randomname653
Randomname653 deleted the bolt-fast-count-debate-outcome-13032803246625861068 branch October 25, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant