AIMVT-139: migrate remaining dmesg/journal scans to node-scraper#272
Open
speriaswamy-amd wants to merge 2 commits into
Open
AIMVT-139: migrate remaining dmesg/journal scans to node-scraper#272speriaswamy-amd wants to merge 2 commits into
speriaswamy-amd wants to merge 2 commits into
Conversation
Route verify_dmesg_for_errors, full_journalctl_scan and verify_driver_errors through the node-scraper adapter behind the same CVS_DMESG_PARSER toggle, and consolidate the shared scan loop into _node_scraper_scan(). - cvs_dmesg_error_regex(): expose CVS's err_patterns_dict as case-insensitive node-scraper error_regex extensions so nothing the legacy regex caught is lost (added on top of node-scraper's built-in table) - verify_dmesg_for_errors: replace sed/awk timestamp slicing with the analyzer's analysis_range_start/end; _parse_cvs_time() converts the `date +"%a %b %e %H:%M"` strings to tz-aware datetimes - full_journalctl_scan: scan the full kernel journal (journalctl -k -o short-iso) instead of the lossy egrep prefilter - verify_driver_errors: parse full dmesg, then keep this check driver-focused by reporting amdgpu/SW_DRIVER events only - full_dmesg_scan: reuse the shared helper + CVS pattern extensions - tests cover all node-scraper paths, time-range args, driver filtering, _parse_cvs_time, and cvs_dmesg_error_regex Co-authored-by: Cursor <cursoragent@cursor.com>
Drop is_available mocks from TestDmesgMigrations; the adapter no longer exposes that helper after PR #221 merged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_dmesg_for_errors,full_journalctl_scan, andverify_driver_errorsto the node-scraper adapter behindCVS_DMESG_PARSER(builds on merged AIMVT-139: node-scraper offline dmesg adapter + full_dmesg_scan toggle #221)._node_scraper_scan()plus helpers:cvs_dmesg_error_regex()(legacy pattern extensions),_parse_cvs_time()(tz-aware time windows).full_dmesg_scanto reuse the shared helper and CVS pattern extensions.Test plan
python -m unittest cvs.lib.unittests.test_verify_lib.TestDmesgMigrationspython -m unittest cvs.lib.unittests.test_verify_lib.TestFullDmesgScanCVS_DMESG_PARSER=legacystill uses regex paths for all four scannersjournalctl -k -o short-isocollection commandsMade with Cursor