Capture vllm server log into test_vllm_inference output#270
Open
atnair-amd wants to merge 1 commit into
Open
Conversation
_check_early_failure() only tails the server log during startup, so a mid-benchmark crash (e.g. EngineDeadError) currently vanishes from the captured pytest output. Add VllmJob.dump_server_log(), mirroring the existing dump_client_log() pattern but per-rank, skipping ray-backend headless workers (rank > 0) which never run vllm serve. Wire it into test_vllm_inference's failure path only, tracking lifecycle.live_server_job so the dump targets whichever job actually owns the running server -- on the reuse path (cells that only differ by concurrency) that's an earlier cell's job, not the current one.
atnair-amd
marked this pull request as ready for review
July 24, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_early_failure()only tails the vLLM server log during thestartup/readiness wait; nothing re-checks it afterward, so a
mid-benchmark server crash (e.g.
EngineDeadError) never appears intest_vllm_inference's captured output.Change
VllmJob.dump_server_log(), mirroring the existingdump_client_log()pattern but per-rank, skipping ray-backendheadless workers (rank > 0), which never run
vllm servetest_vllm_inference's failure path, vialifecycle.live_server_jobso the dump targets whichever jobactually owns the running server (on the server-reuse path, an
earlier cell's job -- not the current cell's, which never issued
build_server_cmd()/start_server())not per-cell, so dumping on every passing cell sharing a reused
server would re-emit the same growing log repeatedly
Tests
TestDumpServerLog(3 cases: full content, mp-backend dumpsevery rank, ray-backend skips worker ranks) in
test_vllm_job_server_reuse.py.test_venv/bin/python -m unittest discover -s cvs/lib/inference/unittests -p "test_vllm_job*.py"(92 passed)cvs/lib/inference/unittestsdiscovery: 205/207 passed (2pre-existing failures in
test_inferencing_config_loader.py,unrelated, reproduced identically on unmodified
dev/dtni)