Skip to content

[FLYDSL] mfma16_hip GDR K5 prefill chunk_gdn_fwd_h for MI308#4353

Open
huizzhan wants to merge 2 commits into
mainfrom
dev/huizzhan/flydsl_gdr_prefill_k5_mi308
Open

[FLYDSL] mfma16_hip GDR K5 prefill chunk_gdn_fwd_h for MI308#4353
huizzhan wants to merge 2 commits into
mainfrom
dev/huizzhan/flydsl_gdr_prefill_k5_mi308

Conversation

@huizzhan

Copy link
Copy Markdown
Contributor

Trim the FlyDSL GDN prefill down to the mfma16_hip fork for the MI308/gfx942 target: drop the other forks (kv/mfma32_vk/2wave/3wave/naive/naive_opt/hipport) and the flydsl csv/heuristic BV logic; BV selection now uniformly reuses the hip K5 _select_bv_for_varlen/_dense. Test kept to the mfma16_hip correctness suite; run script runs it.

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Trim the FlyDSL GDN prefill down to the mfma16_hip fork for the MI308/gfx942
target: drop the other forks (kv/mfma32_vk/2wave/3wave/naive/naive_opt/hipport)
and the flydsl csv/heuristic BV logic; BV selection now uniformly reuses the
hip K5 _select_bv_for_varlen/_dense. Test kept to the mfma16_hip correctness
suite; run script runs it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@huizzhan
huizzhan requested a review from a team July 23, 2026 10:32
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4353 --add-label <label>

…BV select

The mfma16_hip-only dispatch now uses the hip K5 BV selector, so the flydsl
csv/heuristic BV constants (_BV_CANDIDATES, _TUNED_BV_*, _GFX942/950 CTA
targets, _IS_GFX950) and their comments are unreferenced dead code -- drop
them (keep _IS_GFX942, used by the sched_gfx942 gate).

Co-authored-by: Cursor <cursoragent@cursor.com>
@zufayu
zufayu requested a review from coderfeli July 24, 2026 01:32
@huizzhan huizzhan changed the title [flydsl] mi308: mfma16_hip-only K5 prefill (unified hip BV select) [FLYDSL] mfma16_hip GDR K5 prefill chunk_gdn_fwd_h for MI308 Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant