Skip to content

fix(mla): refresh gfx950 MLA HSACO batch for large page_id#4351

Open
fangche123 wants to merge 1 commit into
mainfrom
chefang_mla_global_fix_i24
Open

fix(mla): refresh gfx950 MLA HSACO batch for large page_id#4351
fangche123 wants to merge 1 commit into
mainfrom
chefang_mla_global_fix_i24

Conversation

@fangche123

Copy link
Copy Markdown
Contributor

Rebuild 20 gfx950 MLA kernels (a8w8/a16w16; qh16/qh32/qh64; ps and lse variants) after CKV_mem_va_upd uses v_mul_lo_u32 with v_mul_hi_u32 so kv_indices with page_id >= 2^24 and byte offsets beyond 4GiB are correct.

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Rebuild 20 gfx950 MLA kernels (a8w8/a16w16; qh16/qh32/qh64; ps and lse variants) after CKV_mem_va_upd uses v_mul_lo_u32 with v_mul_hi_u32 so kv_indices with page_id >= 2^24 and byte offsets beyond 4GiB are correct.
@fangche123
fangche123 requested review from a team and Copilot July 23, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4351 --add-label <label>

@zufayu
zufayu requested a review from amd-ruitang3 July 24, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants