fix(mla): refresh gfx950 MLA HSACO batch for large page_id#4351
Open
fangche123 wants to merge 1 commit into
Open
fix(mla): refresh gfx950 MLA HSACO batch for large page_id#4351fangche123 wants to merge 1 commit into
fangche123 wants to merge 1 commit into
Conversation
Rebuild 20 gfx950 MLA kernels (a8w8/a16w16; qh16/qh32/qh64; ps and lse variants) after CKV_mem_va_upd uses v_mul_lo_u32 with v_mul_hi_u32 so kv_indices with page_id >= 2^24 and byte offsets beyond 4GiB are correct.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild 20 gfx950 MLA kernels (a8w8/a16w16; qh16/qh32/qh64; ps and lse variants) after CKV_mem_va_upd uses v_mul_lo_u32 with v_mul_hi_u32 so kv_indices with page_id >= 2^24 and byte offsets beyond 4GiB are correct.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist