Repository navigation
Fix/shiny oauth arcgis compatibility - #101
Merged
JosiahParry merged 3 commits intoSep 16, 2026
Merged
Conversation
JosiahParry
requested changes
Sep 16, 2026
Collaborator
|
Much appreciated!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am working on updating shinyOAuth, and in the process of checking this reverse dependency I found some issues.
Here's a small PR addressing the following:
The Shiny OAuth provider currently selects the organization ID from the portal response, so users in the same organization receive the same selected identity. Select
user$idinstead, while preserving the complete portal profile returned to applications.ArcGIS documents authorization-code and refresh token responses without
token_type. Those responses currently fail shinyOAuth's required-field check. In shinyOAuth 0.6.0, I've added the provider optionallow_missing_token_type = TRUE. This assumes Bearer when the field is absent.The fixes are separate commits:
23b2968: select the authenticated user ID, with a regression test for two users in the same organization.261bd43: enable missing-token-type compatibility, with HTTP-mocked login and refresh tests using documented-style ArcGIS responses.Note: this requires shinyOAuth 0.6.0 to be released before merging.
I am currently submitting that to CRAN.
Hope this helps, feel free to edit.
References: ArcGIS token responses, portal response structure, OAuth 2.0 required token type.