Skip to content

cext: fix UB writing to uninitialized buffers in transpile_layout C API #16590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shofiqtest wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cext: fix UB writing to uninitialized buffers in transpile_layout C API #16590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions crates/cext/src/transpiler/transpile_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,9 @@ pub unsafe extern "C" fn qk_transpile_layout_initial_layout(
// SAFETY: Per the documentation initial_layout must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice =
std::slice::from_raw_parts_mut(initial_layout, out_initial_layout.len());
out_slice
.iter_mut()
.zip(out_initial_layout.iter())
.for_each(|(dest, src)| *dest = src.0);
for (i, src) in out_initial_layout.iter().enumerate() {
initial_layout.add(i).write(src.0);
}
};
true
} else {
Expand Down Expand Up @@ -160,11 +157,9 @@ pub unsafe extern "C" fn qk_transpile_layout_output_permutation(
// SAFETY: Per the documentation output_permutation must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice = std::slice::from_raw_parts_mut(output_permutation, permutation.len());
out_slice
.iter_mut()
.zip(permutation.iter())
.for_each(|(dest, src)| *dest = src.0);
for (i, src) in permutation.iter().enumerate() {
output_permutation.add(i).write(src.0);
}
};
true
} else {
Expand Down Expand Up @@ -213,11 +208,9 @@ pub unsafe extern "C" fn qk_transpile_layout_final_layout(
// SAFETY: Per the documentation final_layout must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice = std::slice::from_raw_parts_mut(final_layout, result.len());
out_slice
.iter_mut()
.zip(result.iter())
.for_each(|(dest, src)| *dest = src.0);
for (i, src) in result.iter().enumerate() {
final_layout.add(i).write(src.0);
}
}
}

Expand Down