Hotfix: pin ruff in CI (ruff 0.16.0 release turned every PR's lint check red) - #812
Merged
Conversation
ruff 0.16.0 (released today) greatly expanded the default rule set, and the lint job used the archived chartboost/ruff-action@v1 with no version pin, so it always installs the latest ruff. Result: every CI run since this afternoon fails Ruff Linting with ~2,487 repo-wide errors in files the PRs never touched (verified locally: 0.15.21 reports "All checks passed!" on the same tree). Switch to the maintained astral-sh/ruff-action@v3 pinned to 0.15.21, the version that CI was effectively using until today. Adopting (or configuring away) the new 0.16 rules can be decided separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 76.33% 76.34%
=======================================
Files 170 170
Lines 22628 22628
=======================================
+ Hits 17274 17276 +2
+ Misses 5354 5352 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix — every open PR is currently failing the Ruff Linting check (#810, #811, and anything else that runs CI from now on), through no fault of their own.
What happened
UP*,TRY*,FURB*,SIM*,PL*,EXE001, ...).chartboost/ruff-action@v1— an archived action — with no version pin, so it installs whatever ruff is latest at run time.doc/src/conf.py, example models).The fix
Switch to the maintained
astral-sh/ruff-action@v3pinned toversion: "0.15.21"— the version CI was effectively using until today. A comment in the workflow explains why the pin must be bumped deliberately, not floated.Whether to adopt (or configure away) the new 0.16 default rules is a separate decision that can be made calmly later.
After this merges, #810 and #811 just need a rebase or a re-run against main to go green on lint.
🤖 Generated with Claude Code