-
Notifications
You must be signed in to change notification settings - Fork 496
feat: deprecate VoiceRegion enum in favour of dynamic voice regions #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmphase
wants to merge
17
commits into
master
from
feat/dynamic-voice-regions
base: master
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−75
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3c61693
feat: deprecate VoiceRegion enum in favour of dynamic voice regions
ddd0d1b
style(pre-commit): auto fixes from pre-commit.com hooks
b9e9c6c
feat(enums): deprecate VoiceRegion enum for LSP; warn on VoiceRegion("")
19dfe2a
feat(enums): unknown attribute fallback
53eb128
feat: make rtc_region paramater accept str (region id) for channel
12acd61
style(pre-commit): auto fixes from pre-commit.com hooks
2e474dc
refactor(enums): import ordering
0a47380
Update discord/guild.py
9faa308
refactor(types): make VoiceRegion a dataclass
0927a51
refactor(regions): apply review suggestions
fe66309
style(pre-commit): auto fixes from pre-commit.com hooks
fd2b819
chore: rename VoiceRegion to VoiceRegionType for consistency with
74d6623
style(pre-commit): auto fixes from pre-commit.com hooks
defeffb
refactor: change dataclass naming
82bf07f
style(pre-commit): auto fixes from pre-commit.com hooks
3278b89
refactor: apply code review suggestions
4cc7b32
Merge branch 'master' into feat/dynamic-voice-regions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.