Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3251/head:pr-3251
git checkout pr-3251This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3251/head |
Paillat-dev
previously approved these changes
Jun 7, 2026
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
lgtm although we should probably shift focus away from bridge and the exts for the time being until we conclude what to do with them
vmphase
requested changes
Jun 7, 2026
Contributor
Author
|
(Actionable) reviews have been addressed! As for shifting focus, that's understandable. This was just meant to be a quick PR for a simple thing at the end of the day. |
This comment was marked as resolved.
This comment was marked as resolved.
vmphase
reviewed
Aug 1, 2026
Signed-off-by: Soheab <33902984+Soheab@users.noreply.github.com>
Soheab
approved these changes
Oct 1, 2026
vmphase
requested changes
Oct 5, 2026
| from typing_extensions import Self | ||
|
|
||
| from discord.commands import ApplicationContext | ||
| from discord.context_managers import Typing |
Member
There was a problem hiding this comment.
This could go under if TYPE_CHECKING block.
Comment on lines
+19
to
+20
| - Add `typing` context manager for Bridge `Context`s. | ||
| ([#3251](https://github.com/Pycord-Development/pycord/pull/3251)) |
Member
There was a problem hiding this comment.
Suggested change
| - Add `typing` context manager for Bridge `Context`s. | |
| ([#3251](https://github.com/Pycord-Development/pycord/pull/3251)) | |
| - Added `typing` context manager for Bridge `Context`s. | |
| ([#3251](https://github.com/Pycord-Development/pycord/pull/3251)) |
| ) | ||
|
|
||
|
|
||
| class DeferTyping: |
Member
There was a problem hiding this comment.
Missing a class-docstring. Is this intentional?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new function to
BridgeContextand its two subclasses:typing(). InBridgeExtContext, this functions just likeContext.typing, but inBridgeApplicationContext, this does a defer. This is most useful when you have a long running bridge command that lasts longer than whattrigger_typing()allows.An example (which showcases this better than any description could do) is below:
This is a breaking change.
ApplicationContexthas atyping()function that types in the channel the command is being run, although the usefulness of this is debatable for slash commands; regardless, this overwrites that function.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.