Skip to content

fix operational reserve constraints #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fneum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix operational reserve constraints #2178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6d172
fix operational reserve constraints
fneum May 22, 2026
db77cfb
revert accidental changes, better noqa handling
fneum May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Release Notes
.. Upcoming Release
.. =================

* Fix: Operational reserve margin constraints now work for PyPSA v1.0. Load shedding generators are now excluded from reserve margin calculations. Renewable generators are now identified based on the configuration rather than presence of ``p_max_pu`` data. Fixed for networks without extendable generators.

* Fix: ``atlite.plot_availability_matrix`` config option for :mod:`determine_availability_matrix` and :mod:`determine_availability_matrix_MD_UA` scripts, changed their output and behaviour to align consistently (https://github.com/PyPSA/pypsa-eur/pull/2173).

* Fix: Activate losses for `H2 pipeline retrofitted` links by default, to ensure consistency with `H2 pipeline` links.
Expand Down
70 changes: 37 additions & 33 deletions scripts/solve_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import yaml
from linopy.remote.oetc import OetcCredentials, OetcHandler, OetcSettings
from pypsa.descriptors import get_activity_mask
from pypsa.descriptors import get_switchable_as_dense as get_as_dense

from scripts._benchmark import memory_logger
from scripts._helpers import (
Expand Down Expand Up @@ -825,7 +824,7 @@ def add_SAFE_constraints(n, config):
def add_operational_reserve_margin(n, sns, config):
"""
Build reserve margin constraints based on the formulation given in
https://genxproject.github.io/GenX/dev/core/#Reserves.
https://genxproject.github.io/GenX.jl/stable/Model_Reference/core/#Operational-Reserves.

Parameters
----------
Expand All @@ -836,66 +835,71 @@ def add_operational_reserve_margin(n, sns, config):
Example:
--------
config.yaml requires to specify operational_reserve:
operational_reserve: # like https://genxproject.github.io/GenX/dev/core/#Reserves
operational_reserve:
activate: true
epsilon_load: 0.02 # percentage of load at each snapshot
epsilon_vres: 0.02 # percentage of VRES at each snapshot
contingency: 400000 # MW
contingency: 4000 # MW
"""
reserve_config = config["electricity"]["operational_reserve"]
EPSILON_LOAD = reserve_config["epsilon_load"]
EPSILON_VRES = reserve_config["epsilon_vres"]
CONTINGENCY = reserve_config["contingency"]

vres_carriers = [ # noqa: F841
"ror" if c == "hydro" else c
for c in config["electricity"]["renewable_carriers"]
]
generator_dim = "Generator" if not PYPSA_V1 else "name"

gen_i = n.generators.query("carrier != 'load'").index # exclude load shedding
fix_i = n.generators.loc[gen_i].query("not p_nom_extendable").index
ext_i = n.generators.loc[gen_i].query("p_nom_extendable").index
vres_i = n.generators.loc[gen_i].query("carrier in @vres_carriers").index

# Reserve Variables
n.model.add_variables(
0, np.inf, coords=[sns, n.generators.index], name="Generator-r"
)
n.model.add_variables(0, np.inf, coords=[sns, gen_i], name="Generator-r")
reserve = n.model["Generator-r"]
summed_reserve = reserve.sum("Generator")
lhs = reserve.sum(generator_dim)

# Share of extendable renewable capacities
ext_i = n.generators.query("p_nom_extendable").index
vres_i = n.generators_t.p_max_pu.columns
if not ext_i.empty and not vres_i.empty:
capacity_factor = n.generators_t.p_max_pu[vres_i.intersection(ext_i)]
p_nom_vres = n.model["Generator-p_nom"].loc[vres_i.intersection(ext_i)]
if not PYPSA_V1:
p_nom_vres = p_nom_vres.rename({"Generator-ext": "Generator"})
lhs = summed_reserve + (
p_nom_vres * (-EPSILON_VRES * xr.DataArray(capacity_factor))
).sum("Generator")
lhs += (p_nom_vres * (-EPSILON_VRES * xr.DataArray(capacity_factor))).sum(
generator_dim
)

# Total demand per t
demand = get_as_dense(n, "Load", "p_set").sum(axis=1)
# Total demand per t
demand = n.get_switchable_as_dense("Load", "p_set").sum(axis=1)

# VRES potential of non extendable generators
capacity_factor = n.generators_t.p_max_pu[vres_i.difference(ext_i)]
renewable_capacity = n.generators.p_nom[vres_i.difference(ext_i)]
potential = (capacity_factor * renewable_capacity).sum(axis=1)
# VRES potential of non extendable generators
capacity_factor = n.generators_t.p_max_pu[vres_i.difference(ext_i)]
renewable_capacity = n.generators.p_nom[vres_i.difference(ext_i)]
potential = (capacity_factor * renewable_capacity).sum(axis=1)

# Right-hand-side
rhs = EPSILON_LOAD * demand + EPSILON_VRES * potential + CONTINGENCY
# Right-hand-side
rhs = EPSILON_LOAD * demand + EPSILON_VRES * potential + CONTINGENCY

n.model.add_constraints(lhs >= rhs, name="reserve_margin")
n.model.add_constraints(lhs >= rhs, name="reserve_margin")

# additional constraint that capacity is not exceeded
gen_i = n.generators.index
ext_i = n.generators.query("p_nom_extendable").index
fix_i = n.generators.query("not p_nom_extendable").index

dispatch = n.model["Generator-p"]
dispatch = n.model["Generator-p"].sel(name=gen_i)
reserve = n.model["Generator-r"]
lhs = dispatch + reserve

capacity_variable = n.model["Generator-p_nom"]
if not PYPSA_V1:
capacity_variable = capacity_variable.rename({"Generator-ext": "Generator"})
capacity_fixed = n.generators.p_nom[fix_i]

p_max_pu = get_as_dense(n, "Generator", "p_max_pu")
p_max_pu = n.get_switchable_as_dense("Generator", "p_max_pu")

lhs = dispatch + reserve - capacity_variable * xr.DataArray(p_max_pu[ext_i])
if not ext_i.empty:
capacity_variable = n.model["Generator-p_nom"].sel(name=ext_i)
if not PYPSA_V1:
capacity_variable = capacity_variable.rename({"Generator-ext": "Generator"})
lhs -= capacity_variable * xr.DataArray(p_max_pu[ext_i])

capacity_fixed = n.generators.p_nom[fix_i]
rhs = (p_max_pu[fix_i] * capacity_fixed).reindex(columns=gen_i, fill_value=0)

n.model.add_constraints(lhs <= rhs, name="Generator-p-reserve-upper")
Expand Down