fix: garbage collection issues for #[pyclass(dict)] - #6206
Merged
Conversation
rewitt94
force-pushed
the
pyclass-dict-gc-fixes
branch
from
July 15, 2026 14:32
fa6a510 to
f3369bc
Compare
davidhewitt
approved these changes
Jul 24, 2026
Member
There was a problem hiding this comment.
I didn't know towncrier supported .1.md etc for additional files; I just verified this works with towncrier build, nice 😂
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
|
@davidhewitt @rewitt94 I think a specific test here introduced flakyness in CI (also reproducible locally) => #6243 I'm not an expert on this, but I left a "Suggested fix" section with various approaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contains two fixes for GC of
#[pyclass(dict)]#[pyclass(dict)]without a user defined__traverse__function did not define a required GC slots on the PyTypeObject to become discoverable to the cyclic garbage collector.Solution: now defined regardless in
create_type_object.Early returns (when there are live references we can early return i.e. tell cyclic GC we can't clear) in
_call_traversedid not drop lock / disarm trap which would cause a crash.Solution: Logic is now nested into inner function that can safely early return.
Related to issue #5953 / PR #6198 (no overlap with PR)