Skip to content

fix: use checkMemberGroups for security group membership - #1383

Open
damsleth wants to merge 1 commit into
devfrom
fix/msgraph-check-member-groups
Open

fix: use checkMemberGroups for security group membership#1383
damsleth wants to merge 1 commit into
devfrom
fix/msgraph-check-member-groups

fix: use checkMemberGroups for security group membership

981b7ac
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2026-04-24 10:32:22 ago

1 / 4 tasks completed

3 tasks still to be completed

Details

Required Tasks

Task Status
npm run lint passes Completed
npm test - the four new isUserMemberOfSecurityGroup cases pass in isolation. Note: several pre-existing tests (ReportService.test.ts, passport/index.test.ts, timesheet/extensions.test.ts) fail compilation under ts-node with TS2694: Namespace 'global.Express' has no exported member 'User' on this worktree. This is unrelated to this change (reproduces on clean origin/dev) and appears to pre-date this PR; flagged here for awareness. Incomplete
Manual sign-in smoke test with a small security group - confirm existing member still signs in. Incomplete
Manual sign-in smoke test with a group that has >100 members - previously broken, should now succeed. Incomplete