Skip to content

perf: detach children inline in Empty() #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvoisin wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −2
Open

perf: detach children inline in Empty() #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions manipulation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,20 @@ func (s *Selection) Empty() *Selection {
var nodes []*html.Node

for _, n := range s.Nodes {
for c := n.FirstChild; c != nil; c = n.FirstChild {
n.RemoveChild(c)
// Detach all children in one pass. Since each child is being
// removed from its only parent and ends up with no siblings,
// we can inline what RemoveChild does for the FirstChild case
// and skip the per-iter FirstChild/LastChild bookkeeping.
for c := n.FirstChild; c != nil; {
next := c.NextSibling
c.Parent = nil
c.PrevSibling = nil
c.NextSibling = nil
nodes = append(nodes, c)
c = next
}
n.FirstChild = nil
n.LastChild = nil
}

return pushStack(s, nodes)
Expand Down
Loading