fix(cli): #1715 split active content keys on first hyphen so hyphenated collections resolve#1716
Open
jstockdi wants to merge 1 commit into
Conversation
…phen so hyphenated collections resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #1715
Documentation
N/A — no user-facing documentation changes (bug fix only; the
collection-<name>/route-<route>content key format is unchanged).Summary of Changes
remaining hyphens, in
packages/cli/src/plugins/resource/plugin-active-content.js(server
/___graph.jsonhandler) andpackages/cli/src/data/client.js(client-sidegetContentByCollection/getContentByRoutewhen not prerendering).my-posts) now resolve to their pages instead of[];hyphenated routes (e.g.
/my-blog) keep their full value instead of being truncated to aprefix that over-matches.
graph,collection-nav,route-/blog) is unchanged.packages/cli/test/cases/develop.config.active-content-collection-hyphen/that serves acollection named
my-postsacross two pages and assertsX-CONTENT-KEY: collection-my-postsreturns those pages (fails with[]on unpatched source).