fix(cli): #1709 guard frontmatter title/label/id decode so a literal % cannot crash the build#1710
Open
jstockdi wants to merge 1 commit into
Conversation
…de so a literal % cannot crash the build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #1709
Documentation
N/A — no user-facing documentation changes (bug fix only).
Summary of Changes
safeDecodeURIComponenthelper inpackages/cli/src/lifecycles/graph.jsthat wrapsdecodeURIComponentin atry/catch and returns the original string on
URIError.id,label, andtitledecodes so validpercent-encoded filenames still decode, but a literal
%in frontmatter(e.g.
100% Complete,Save 20%) can no longer crash the build.packages/cli/test/cases/build.default.frontmatter-percent/with a fixturepage whose frontmatter title/label contain
%, asserting the build succeedsand the title reaches the output verbatim.
before; only the previously-fatal malformed-input path now falls back to the
raw string.