Repository navigation
# My 28 open PRs, grouped #4134
Description
My 28 open PRs, grouped
"mergeable" below means GitHub reports no conflicts; several PRs show blocked only because the repo requires a review.
PRs waiting on another PR or a release
| Prerequisite | PR | State |
|---|---|---|
| PrismarineJS/minecraft-data-generator#86 (produces the data) | PrismarineJS/minecraft-data#1307 | ready, green - the data is committed, so it does not strictly wait; the generator PR is what makes it reproducible |
| PrismarineJS/minecraft-data-generator#87 | PrismarineJS/minecraft-data#1309 | ready, green - same relationship |
| PrismarineJS/minecraft-data-generator#88 | PrismarineJS/minecraft-data#1310 | ready, green - same relationship; stacked, see below |
| PrismarineJS/minecraft-data#1308 released, then PrismarineJS/node-minecraft-data#457 (open, behind master, no conflicts) | PrismarineJS/prismarine-block#127 | ready, green - safe to merge now; without registry.tags it is the old path byte-for-byte |
| PrismarineJS/minecraft-data-generator#85 (produces the data) | PrismarineJS/minecraft-data#1296 | not ready, red - the build job's node process crashed (Unknown bind__() error, exit 139) |
| PrismarineJS/minecraft-data#1296 merged and the submodule bumped | PrismarineJS/node-minecraft-data#468 | not ready, red - index.d.ts: Cannot find name 'BlockSelectionShapes': the type is generated from #1296's schema, so red until the submodule carries it |
| PrismarineJS/minecraft-data#1296 + PrismarineJS/node-minecraft-data#468 at runtime | PrismarineJS/prismarine-block#125 | ready, green - falls back to collision geometry without the data, so mergeable alone |
| PrismarineJS/node-minecraft-protocol#1528 merged and released | PrismarineJS/node-minecraft-protocol-forge#51 | ready, green - tested against #1528 linked locally, not a released dependency |
| PrismarineJS/minecraft-data#1288 released (correct 1.20.5/1.20.6 defaults at runtime) | PrismarineJS/prismarine-item#186 | ready, green - rebased over #185, mergeable; see "awaiting re-review" |
| PrismarineJS/minecraft-data-generator#83 (produces the data) | PrismarineJS/minecraft-data#1290 | ready, green - see "awaiting re-review" |
| PrismarineJS/minecraft-data#1290 (data) | PrismarineJS/prismarine-item#187 | ready, green - the consumer can land first; it is compatible with data that lacks the new fields |
Stacked on another open PR's branch
| PR | State | Based on |
|---|---|---|
| PrismarineJS/minecraft-data-generator#88 | ready, green | PrismarineJS/minecraft-data-generator#87 (same file; #88's diff includes #87's commit until it lands) |
| PrismarineJS/minecraft-data#1310 | ready, green | PrismarineJS/minecraft-data#1309 (same files; same note) |
Awaiting maintainer re-review
Pushed after the last review; no maintainer activity since.
| PR | State | Last exchange |
|---|---|---|
| PrismarineJS/minecraft-data#1290 | ready, green | @extremeheat reviewed 11–12 Sep (inline Remove, now outdated); addressed and pushed 12 Sep; enhancement label added 16 Sep |
| PrismarineJS/node-minecraft-protocol#1521 | not ready, red | @extremeheat asked 6 Sep whether it was tested against the server-side implementation and suggested a real-server test; follow-up pushed. The red test (26.1) job died in the status-ping test (Connection closed before the server sent a status response), unrelated to the change |
| PrismarineJS/prismarine-item#186 | ready, green | @extremeheat on 11 Sep asked for proper item-component handling and questioned removedComponents as stored state; the second commit implements a shared ItemComponents state with removedComponents as a derived view. Rebased over #185, title/description updated and replied 18 Sep |
Other contributors' PRs that overlap
| Mine | Theirs | Relationship |
|---|---|---|
| PrismarineJS/minecraft-data#1307 | PrismarineJS/minecraft-data#1232 (open) | same bug, data-only patch of materials.json; leaves wooden shovel/axe/hoe 2x fast on 108 blocks. Superseded. |
| PrismarineJS/prismarine-block#127 | PrismarineJS/prismarine-block#123 (open) | consumer fallback for the same bug; wrong for golden pickaxe and for blocks with empty harvestTools. Superseded. |
| PrismarineJS/minecraft-data#1308 | PrismarineJS/minecraft-data#1080 (open), PrismarineJS/minecraft-data-generator#56 (open) | the Java TagsDataGenerator route; only compiles on 1.21.6+, and #1080's file fails #1194's audit. Superseded by jar extraction. |
| PrismarineJS/minecraft-data#1308 | PrismarineJS/minecraft-data#1194 (open, conflicting) | #1308 adopts this schema and includes the file so it validates standalone; if #1194 lands first I drop it and rebase |
| PrismarineJS/minecraft-data-generator#86 | PrismarineJS/minecraft-data-generator#77 (open), PrismarineJS/minecraft-data#1298 (open, clean) | the 26.2 module and data still carry the pre-#71 code and 108 incorrect_for_wooden_tool blocks; commented on both |
| #4051 | #4087 (u9g, open) | #4087 has the broader status sequence, #4051 the per-version codec regression; one current-base PR should combine them. #3842 is closed; its raw-UUID part shipped in #4061. |
| PrismarineJS/node-minecraft-protocol-forge#51 | PrismarineJS/node-minecraft-protocol-forge#46 (open), PrismarineJS/node-minecraft-protocol-forge#43 (open) | #46 overlaps the mod-list override and can close after #51; #43's FML3 status-ping decoder is separate - merge it first or fold it in with attribution |
| PrismarineJS/prismarine-schematic#85 | PrismarineJS/prismarine-schematic#61 (open) | #85 is the alternative that incorporates #61's format-detection and error-handling feedback; close #61 in favour |
| PrismarineJS/prismarine-physics#141 | PrismarineJS/prismarine-physics#140 (open) | complementary, not overlapping: #141 handles vertical support growth at the start of collision handling |
Issues these close or answer
#3921, PrismarineJS/minecraft-data#987, PrismarineJS/prismarine-block#69 (dig time; #4131 already closed); PrismarineJS/minecraft-data#412 (tags direction); #3985 (#4052); #4044 (#4051); PrismarineJS/prismarine-schematic#82 and #38 (#85); PrismarineJS/prismarine-physics#113 (#141); PrismarineJS/prismarine-chunk#229 (#332).
PRs ready to review
Green CI or infrastructure-only red (table above), mergeable, not waiting on another PR or a release.
| PR | Status |
|---|---|
| PrismarineJS/minecraft-data-generator#86 | ready - CI re-run |
| PrismarineJS/minecraft-data#1307 | ready, green |
| PrismarineJS/minecraft-data-generator#87 | ready - CI re-run |
| PrismarineJS/minecraft-data#1309 | ready, green |
| PrismarineJS/minecraft-data#1308 | ready, green |
| PrismarineJS/prismarine-block#127 | ready, green |
| PrismarineJS/minecraft-data-generator#84 | ready, green |
| PrismarineJS/minecraft-data#1288 | ready, green |
| PrismarineJS/prismarine-item#187 | ready, green |
| PrismarineJS/prismarine-block#125 | ready, green |
| PrismarineJS/prismarine-world#165 | ready, green |
| PrismarineJS/node-minecraft-protocol#1528 | ready, green - unblocks PrismarineJS/node-minecraft-protocol-forge#51 |
| PrismarineJS/node-minecraft-protocol-forge#51 | ready, green - dependency pin finalised once #1528 releases |
| #4051 | ready, green - consolidate with #4087 (either direction) |
| #4052 | ready, green |
| PrismarineJS/prismarine-chunk#332 | ready, green |
| PrismarineJS/prismarine-physics#141 | ready, green |
| PrismarineJS/prismarine-schematic#85 | ready, green |
(18 PRs; plus #88 / #1310 once their bases land, and #1290 / #186 once re-reviewed)
A. Dig time: materials, tags, consumer - 8
Started from #4131. Three generator defects and their data, then the tags data that replaces the material model, then the consumer. Each PR carries its own full-matrix verification and a live vanilla 26.1 run.
| PR | Title | Status |
|---|---|---|
| PrismarineJS/minecraft-data-generator#86 | Fix composite material regression from #71 and apply the fix to 26.1 | ready - CI re-run |
| PrismarineJS/minecraft-data#1307 | pc: fix block material for tier-gated blocks (1.20.5–26.1) | ready, green |
| PrismarineJS/minecraft-data-generator#87 | Add copper tool speed to the materials speed table (1.21.9+) | ready - CI re-run |
| PrismarineJS/minecraft-data#1309 | pc: fix copper tool speeds in materials.json (1.21.9–26.1) | ready, green |
| PrismarineJS/minecraft-data-generator#88 | Keep the shears speed special cases when walking tool components (1.21.5+) | ready, green - stacked on #87 |
| PrismarineJS/minecraft-data#1310 | pc: fix shears speed on leaves and wool in materials.json (1.21.5–26.1) | ready, green - stacked on #1309 |
| PrismarineJS/minecraft-data#1308 | Add pc tags data extracted from the vanilla server jar (1.13–26.1) | ready, green - supersedes #1080 / generator #56; includes #1194's schema |
| PrismarineJS/prismarine-block#127 | Compute dig time from block tags when the registry has them | ready, green - live after #1308 + node-minecraft-data#457 |
B. Cursor targeting: block selection shapes - 5
Crops and non-colliding plants cannot be targeted because mineflayer raycasts against collision shapes. Independent world fix, then producer -> data -> API -> consumer; the mineflayer companion is validated on all 28 supported versions and follows once these land.
| PR | Title | Status |
|---|---|---|
| PrismarineJS/prismarine-world#165 | Fix ray intersections on parallel shape boundaries | ready, green - independent |
| PrismarineJS/minecraft-data-generator#85 | Extract Java block selection shapes separately from collision shapes | not ready - CI re-run (maven timeouts + cancellations) |
| PrismarineJS/minecraft-data#1296 | Add generated Java block selection-shape data | not ready, red - node crash in build; after generator #85 |
| PrismarineJS/node-minecraft-data#468 | Expose block selection shapes in the data API | not ready, red - generated type missing until #1296 is in the submodule |
| PrismarineJS/prismarine-block#125 | Add interactionShapes without changing collision geometry | ready, green - collision fallback, mergeable alone |
C. Items: durability, enchantments, display names - 7
Stale 1.20.5 durability data, enchantment applicability that the broad category model cannot express, and legacy display names.
| PR | Title | Status |
|---|---|---|
| PrismarineJS/minecraft-data-generator#82 | Fix generator startup and item data | not ready - CI re-run (connection reset on 1.20.4) |
| PrismarineJS/minecraft-data#1288 | Fix Java 1.20.5 item durability data | ready, green - independent of #82 |
| PrismarineJS/prismarine-item#186 | Resolve item component updates and remaining durability | ready, green - implements the component system requested in review; awaiting re-review |
| PrismarineJS/minecraft-data-generator#83 | Extract native enchantment applicability and rarity | not ready - CI re-run (cancellations) |
| PrismarineJS/minecraft-data#1290 | Add generated enchantment applicability and rarity data | ready, green - awaiting re-review |
| PrismarineJS/prismarine-item#187 | Use explicit enchantment applicability and rarity in anvils | ready, green - can land before #1290 |
| PrismarineJS/minecraft-data-generator#84 | Fix item display-name extraction for 1.11.2 and 1.12.2 | ready, green |
D. Mineflayer behaviour - 2
| PR | Title | Status |
|---|---|---|
| #4051 | send one protocol-shaped decline | ready, green - overlaps #4087; closes #4044 |
| #4052 | Only update oxygen from the bot's metadata | ready, green - closes #3985 |
E. Protocol and mod loaders - 3
| PR | Title | Status |
|---|---|---|
| PrismarineJS/node-minecraft-protocol#1528 | Fix custom protocol isolation and 1.7.10 auto-version selection | ready, green |
| PrismarineJS/node-minecraft-protocol-forge#51 | Add modern Forge, NeoForge, and Fabric protocol support | ready, green - after #1528 releases; overlaps #46, #43 |
| PrismarineJS/node-minecraft-protocol#1521 | checksum last seen messages in acknowledgement order | not ready - awaiting re-review; red job is a status-ping flake |
F. Bedrock, physics, schematics - 3
| PR | Title | Status |
|---|---|---|
| PrismarineJS/prismarine-chunk#332 | Fix Bedrock 1.17.30+ zero-bit palette decoding | ready, green - closes #229 |
| PrismarineJS/prismarine-physics#141 | Keep players above support blocks that grow into their hitbox | ready, green - closes #113; complements #140 |
| PrismarineJS/prismarine-schematic#85 | Add Sponge v3 block data support | ready, green - replaces #61; fixes #82, addresses #38 |
Activity