Skip to content

pc: regenerate block and entity loot for 1.14.4 - 26.1 #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pix3lPirat3 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pc: regenerate block and entity loot for 1.14.4 - 26.1 #1312

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ead6dc
pc: regenerate block and entity loot for 1.14.4 - 26.1
Pix3lPirat3 Sep 18, 2026
6fb17e9
Regenerate multiface loot counts (glow_lichen, sculk_vein, resin_clump)
Pix3lPirat3 Sep 21, 2026
581b841
Clamp negative entity loot count ranges to zero
Pix3lPirat3 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions data/dataPaths.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,8 +1361,8 @@
"version": "pc/1.20.3",
"foods": "pc/1.20.3",
"particles": "pc/1.20.3",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.20.3",
"entityLoot": "pc/1.20.3",
"loginPacket": "pc/1.20.2",
"tints": "pc/1.20.2",
"mapIcons": "pc/1.20.2",
Expand All @@ -1387,8 +1387,8 @@
"version": "pc/1.20.4",
"foods": "pc/1.20.3",
"particles": "pc/1.20.3",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.20.3",
"entityLoot": "pc/1.20.3",
"loginPacket": "pc/1.20.2",
"tints": "pc/1.20.2",
"mapIcons": "pc/1.20.2",
Expand All @@ -1414,8 +1414,8 @@
"version": "pc/1.20.5",
"foods": "pc/1.20.5",
"particles": "pc/1.20.5",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.20.5",
"entityLoot": "pc/1.20.5",
"loginPacket": "pc/1.20.5",
"tints": "pc/1.20.5",
"mapIcons": "pc/1.20.2",
Expand All @@ -1441,8 +1441,8 @@
"version": "pc/1.20.6",
"foods": "pc/1.20.5",
"particles": "pc/1.20.5",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.20.5",
"entityLoot": "pc/1.20.5",
"loginPacket": "pc/1.20.5",
"tints": "pc/1.20.5",
"mapIcons": "pc/1.20.2",
Expand All @@ -1468,8 +1468,8 @@
"version": "pc/1.21",
"foods": "pc/1.21.1",
"particles": "pc/1.20.5",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.21.1",
"entityLoot": "pc/1.21.1",
"loginPacket": "pc/1.21.1",
"tints": "pc/1.21.1",
"mapIcons": "pc/1.20.2",
Expand All @@ -1495,8 +1495,8 @@
"version": "pc/1.21.1",
"foods": "pc/1.21.1",
"particles": "pc/1.20.5",
"blockLoot": "pc/1.20",
"entityLoot": "pc/1.20",
"blockLoot": "pc/1.21.1",
"entityLoot": "pc/1.21.1",
"loginPacket": "pc/1.21.1",
"tints": "pc/1.21.1",
"mapIcons": "pc/1.20.2",
Expand All @@ -1508,13 +1508,13 @@
"attributes": "pc/1.21.3",
"blockCollisionShapes": "pc/1.21.3",
"blocks": "pc/1.21.3",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.3",
"biomes": "pc/1.21.3",
"commands": "pc/1.20.3",
"effects": "pc/1.20.5",
"enchantments": "pc/1.21.1",
"entities": "pc/1.21.3",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.3",
"foods": "pc/1.21.1",
"instruments": "pc/1.20.5",
"items": "pc/1.21.3",
Expand All @@ -1535,13 +1535,13 @@
"attributes": "pc/1.21.3",
"blockCollisionShapes": "pc/1.21.4",
"blocks": "pc/1.21.4",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.4",
"biomes": "pc/1.21.4",
"commands": "pc/1.20.3",
"effects": "pc/1.21.4",
"enchantments": "pc/1.21.1",
"entities": "pc/1.21.4",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.4",

@rom1504 rom1504 Sep 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The 35 multiface records are fixed, but this update did not propagate the producer's new nonnegative clamp to entityLoot. Reprocessing the official 1.21.4 tables with PR15 at 71608f9 now yields [0, 1] for cave-spider/spider eyes, magma-cube cream and wither-skeleton coal; the selected pc/1.21.4/entityLoot.json still contains [-1, 1] or [-2, 1]. The same four negative-range records remain in each of the 19 changed entity-loot files (76 records total).

Please rerun generation for the entity outputs as well, so the checked-in data matches the repaired producer. This is a remaining regeneration gap after the fix, rather than the already-resolved additive multiface problem; no handwritten per-version override is needed.

Skills: prismarine-review checked the new delta and existing feedback; prismarine-protocol-data-review compared native tables/semantics with generated counts; prismarine-architecture-review traced the producer-to-data contract.

"foods": "pc/1.21.1",
"instruments": "pc/1.20.5",
"items": "pc/1.21.4",
Expand All @@ -1562,13 +1562,13 @@
"attributes": "pc/1.21.5",
"blockCollisionShapes": "pc/1.21.5",
"blocks": "pc/1.21.5",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.5",
"biomes": "pc/1.21.5",
"commands": "pc/1.20.3",
"effects": "pc/1.21.5",
"enchantments": "pc/1.21.5",
"entities": "pc/1.21.5",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.5",
"foods": "pc/1.21.5",
"instruments": "pc/1.20.5",
"items": "pc/1.21.5",
Expand All @@ -1589,13 +1589,13 @@
"attributes": "pc/1.21.6",
"blockCollisionShapes": "pc/1.21.6",
"blocks": "pc/1.21.6",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.6",
"biomes": "pc/1.21.6",
"commands": "pc/1.20.3",
"effects": "pc/1.21.6",
"enchantments": "pc/1.21.6",
"entities": "pc/1.21.6",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.6",
"foods": "pc/1.21.6",
"instruments": "pc/1.20.5",
"items": "pc/1.21.6",
Expand All @@ -1616,13 +1616,13 @@
"attributes": "pc/1.21.8",
"blockCollisionShapes": "pc/1.21.8",
"blocks": "pc/1.21.8",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.8",
"biomes": "pc/1.21.8",
"commands": "pc/1.20.3",
"effects": "pc/1.21.8",
"enchantments": "pc/1.21.8",
"entities": "pc/1.21.8",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.8",
"foods": "pc/1.21.8",
"instruments": "pc/1.21.8",
"items": "pc/1.21.8",
Expand All @@ -1643,13 +1643,13 @@
"attributes": "pc/1.21.9",
"blockCollisionShapes": "pc/1.21.9",
"blocks": "pc/1.21.9",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.9",
"biomes": "pc/1.21.9",
"commands": "pc/1.20.3",
"effects": "pc/1.21.9",
"enchantments": "pc/1.21.9",
"entities": "pc/1.21.9",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.9",
"foods": "pc/1.21.9",
"instruments": "pc/1.21.9",
"items": "pc/1.21.9",
Expand All @@ -1670,13 +1670,13 @@
"attributes": "pc/1.21.9",
"blockCollisionShapes": "pc/1.21.9",
"blocks": "pc/1.21.9",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.9",
"biomes": "pc/1.21.9",
"commands": "pc/1.20.3",
"effects": "pc/1.21.9",
"enchantments": "pc/1.21.9",
"entities": "pc/1.21.9",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.9",
"foods": "pc/1.21.9",
"instruments": "pc/1.21.9",
"items": "pc/1.21.9",
Expand All @@ -1697,13 +1697,13 @@
"attributes": "pc/1.21.11",
"blockCollisionShapes": "pc/1.21.11",
"blocks": "pc/1.21.11",
"blockLoot": "pc/1.20",
"blockLoot": "pc/1.21.11",
"biomes": "pc/1.21.11",
"commands": "pc/1.20.3",
"effects": "pc/1.21.11",
"enchantments": "pc/1.21.11",
"entities": "pc/1.21.11",
"entityLoot": "pc/1.20",
"entityLoot": "pc/1.21.11",
"foods": "pc/1.21.11",
"instruments": "pc/1.21.11",
"items": "pc/1.21.11",
Expand All @@ -1724,13 +1724,13 @@
"attributes": "pc/26.1",
"blockCollisionShapes": "pc/26.1",
"blocks": "pc/26.1",
"blockLoot": "pc/1.20",
"blockLoot": "pc/26.1",
"biomes": "pc/26.1",
"commands": "pc/1.20.3",
"effects": "pc/26.1",
"enchantments": "pc/26.1",
"entities": "pc/26.1",
"entityLoot": "pc/1.20",
"entityLoot": "pc/26.1",
"foods": "pc/26.1",
"instruments": "pc/26.1",
"items": "pc/26.1",
Expand Down
Loading
Loading