Add protocol mapper switch sanity test and correct existing switch errors - #1286
Merged
extremeheat merged 2 commits intoSep 11, 2026
Merged
Conversation
Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add sanity check to prevent switching on undefined map value
Add protocol mapper switch sanity checks
Sep 9, 2026
extremeheat
reviewed
Sep 9, 2026
| if (!mapper.has(value)) issues.push(`${location}: ${options.compareTo} -> ${value}`) | ||
| } | ||
| } else if (options.compareTo) { | ||
| console.log(`${versionString}: unable to find ${options.compareTo} for switch at ${location}`) |
Member
There was a problem hiding this comment.
Hmm. Thinking about it it would make sense to put this into protodef-validator itself. But for now this seems like good stopgap fixing present protocol def bugs
extremeheat
marked this pull request as ready for review
September 9, 2026 05:20
extremeheat
approved these changes
Sep 9, 2026
switch errors
extremeheat
deleted the
copilot/add-sanity-check-to-prevent-undefined-map-value
branch
September 11, 2026 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol switches could reference values absent from their preceding mapper, causing undefined dispatch behavior. Add CI validation to detect these mismatches across protocol JSON files.