Say which container $this->get() resolves against in the front office - #2164
Draft
boo-code wants to merge 1 commit into
Draft
Say which container $this->get() resolves against in the front office#2164boo-code wants to merge 1 commit into
boo-code wants to merge 1 commit into
Conversation
The Symfony Services section describes config/services.yml and $this->get() without saying they only apply to the back office and to migrated pages. The front office caveat is further down the page, under Services in Legacy environment, which is where readers land only after the call has already failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony Servicessection ofmodules/concepts/servicesdescribesconfig/services.ymland$this->get()with no indication that both only apply to the back office and to pages already migrated to Symfony. The front office caveat exists but sits underServices in Legacy environment, several screens further down, which is where a reader lands only after the call has already thrown. Adds a warning notice at the top of the section naming what resolves where, and linking to the existing section.Why here
#29013 is a module author following the top of this page and getting
You have requested a non-existent service "twig"from a front office hook. Twenty-one comments and threecommunity members later, the answer was the paragraph further down the same page. The page is not wrong;
the scoping is stated too late to help.
The facts the notice states, measured on 9.2
A probe module hooked on
displayFooterProduct, hit through a real front office product page:The 109 are Doctrine plus
prestashop.adapter.*/prestashop.core.*entries; the only translation-ishone is
prestashop.translation.translator_language_loader. No count is quoted in the notice, since itwould go stale.