feat(Quran.com): improve reading, reciter, and page activities - #11151
Open
rhuda21 wants to merge 3 commits into
Open
feat(Quran.com): improve reading, reciter, and page activities#11151rhuda21 wants to merge 3 commits into
rhuda21 wants to merge 3 commits into
Conversation
Contributor
🖼️ Activity asset previewAnother day, another diff. Here's everything shiny I could dig out of this one. Quran.com (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://cdn.rcd.gg/PreMiD/websites/Q/Quran.com/assets/logo.png |
 |
thumbnail | https://cdn.rcd.gg/PreMiD/websites/Q/Quran.com/assets/thumbnail.png |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
theusaf
requested changes
Sep 4, 2026
| return verseNumber && chapterNumber ? `${chapterNumber}:${verseNumber}` : undefined | ||
| } | ||
|
|
||
| const translations = { |
Contributor
There was a problem hiding this comment.
Use PreMiD's built-in localization feature instead
Comment on lines
149
to
153
| const newLang = await presence.getSetting<string>('lang').catch(() => 'en') || 'en' | ||
| if (oldLang !== newLang || !strings) { | ||
| oldLang = newLang | ||
| strings = await getStrings() | ||
| } |
Contributor
There was a problem hiding this comment.
oldLang workaround is deprecated. Extension does this automatically and efficiently - just call await getStrings() directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the Quran.com activity with more accurate and detailed presence information. The existing activity no longer matched Quran.com's current structure and functionality.
Changes
1.1.0to1.2.0.Settings
Acknowledgements
npm run lintScreenshots
Proof showing the modification is working as expected