Skip to content

Fix clippy rule violation #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Steve Lee (SteveL-MSFT) wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −10
Open

Fix clippy rule violation #1688

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09f567e
Fix clippy rule violation
SteveL-MSFT Aug 21, 2026
183a666
fix build on Windows
Aug 22, 2026
b3e00cd
Add registry decoder test coverage
Aug 22, 2026
9038510
remove incorrect msrustup env var
Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/dsc-lib/src/functions/int.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ impl Function for Int {

fn invoke(&self, args: &[Value], _context: &Context) -> Result<Value, DscError> {
let arg = &args[0];
let value: i64;
if arg.is_string() {
let value: i64 = if arg.is_string() {
let input = arg.as_str().ok_or(DscError::FunctionArg("int".to_string(), t!("functions.int.invalidInput").to_string()))?;
let result = input.parse::<f64>().map_err(|_| DscError::FunctionArg("int".to_string(), t!("functions.int.parseStringError").to_string()))?;
value = NumCast::from(result).ok_or(DscError::FunctionArg("int".to_string(), t!("functions.int.castError").to_string()))?;
NumCast::from(result).ok_or(DscError::FunctionArg("int".to_string(), t!("functions.int.castError").to_string()))?
} else if arg.is_number() {
value = arg.as_i64().ok_or(DscError::FunctionArg("int".to_string(), t!("functions.int.parseNumError").to_string()))?;
arg.as_i64().ok_or(DscError::FunctionArg("int".to_string(), t!("functions.int.parseNumError").to_string()))?
} else {
return Err(DscError::FunctionArg("int".to_string(), t!("functions.invalidArgType").to_string()));
}
};
Ok(Value::Number(value.into()))
}
}
Expand Down
Loading