Bump cat_tools floor to 0.3.0, wire CI to the git-source override - #25
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f08db32 to
ef2e29d
Compare
The version decision this repo actually needs, separated from PR Postgres-Extensions#10's install-mechanism change. extension_drop.sql calls cat_tools.routine__parse_arg_types_text(), which only exists starting at cat_tools 0.3.0 -- PGXN's published listing is stuck at a stale 2017 0.2.1 lacking it. Bumping META's declared floor makes a plain `pgxn install extension_drop` fail cleanly at dependency-resolution time instead of installing successfully and breaking later at CREATE EXTENSION time. Sets CAT_TOOLS_GIT_REF=0.3.0 at ci.yml's workflow level (not per-job), so every job that builds the extension -- including ones in other stacked PRs that already read this value via `make print-CAT_TOOLS_GIT_REF` -- picks it up automatically. Updates RELEASE.md's release-blocking guardrail: the real signal is now whether ci.yml's CAT_TOOLS_GIT_REF is actually set to a non-empty value, not whether the Makefile merely declares the variable (it always does now, as a normally-empty opt-in override).
fa14f58 to
b9a135c
Compare
|
Claude finished @jnasbyupgrade's task in 3m 6s —— View job Claude's reviewTodo list:
Note on scope: the actual diff ( Findings1. Stale This PR's purpose is bumping the This branch is exactly the path RELEASE.md's new guardrail section describes reverting to once 2. Same issue as above, user-facing this time — should read What looked right
|
Redesigned alongside PR #10's redesign, splitting cleanly: #10 is the
install-mechanism override (
CAT_TOOLS_GIT_REF/CAT_TOOLS_SKIP_INSTALL,defaults empty/unchanged); this PR is the actual version decision.
What this PR does
META.in.json/META.json's declaredcat_toolsfloor from0.2.1to
0.3.0--extension_drop.sqlcallscat_tools.routine__parse_arg_types_text(), which only exists starting atcat_tools 0.3.0. PGXN's published listing is stuck at a stale 2017
0.2.1lacking it, so a plain
pgxn install extension_dropnow fails cleanly atdependency-resolution time instead of installing successfully and breaking
later, obscurely, at
CREATE EXTENSIONtime.CAT_TOOLS_GIT_REF: 0.3.0at.github/workflows/ci.yml's workflowlevel (not per-job), so every job that builds the extension -- including
jobs in other stacked PRs that already read this value via
make print-CAT_TOOLS_GIT_REF(e.g. the pg_tle job) -- picks it upautomatically with no further changes needed there.
RELEASE.md's release-blocking guardrail: the real signal for"is a release actually cuttable" is now whether
ci.yml'sCAT_TOOLS_GIT_REFis set to a non-empty value, not whether the Makefilemerely declares the variable -- it always does now, as a normally-empty
opt-in override, so its mere existence isn't a useful signal anymore.
Verified locally (PG17)
CAT_TOOLS_GIT_REF=0.3.0 make install(the real path CI exercises):installs cat_tools 0.3.0 from git, then installs
extension_dropitself,end to end.
CAT_TOOLS_GIT_REFcorrectly overrides the Makefile's?=(empty)default -- verified via
make -nbefore and after exporting it.