Add explicit vnl fixed-to-dynamic conversions for VXL 2026 / ITK 6 (release-5.4 compatible)#1280
Merged
Sunderlandkyl merged 1 commit intoJul 14, 2026
Conversation
Recent VXL (as vendored by ITK 6) removed the implicit conversions from vnl_matrix_fixed / vnl_vector_fixed to vnl_matrix / vnl_vector, and changed the type returned by member accessors. Add explicit .as_matrix()/.as_vector() conversions in the probe-calibration algorithms, and construct vnl_svd from an .as_matrix() view. These accessors also exist in the ITK release-5.4 VNL, so the change is backward compatible.
hjmjohnson
marked this pull request as ready for review
July 6, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit
.as_matrix()/.as_vector()conversions (andvnl_svd(m.as_matrix())) in the probe-calibration algorithms so PlusLib compiles against the VXL vendored by ITK 6, while staying compatible with ITK release-5.4.Details
VXL 2026 (in ITK 6) removed the implicit
vnl_*_fixed → vnl_*conversions and changed some accessor return types, sovnl_svd<double> svd(fixedMatrix),matrix.update(...GetVnlMatrix()), andvnl_vector<double> v = fixedMatrix.get_column(n)no longer compile. Explicit.as_matrix()/.as_vector()fixes this; both accessors exist in ITK 5.4's VNL too.Verified building PlusLib against ITK 6 and ITK 5.4.6. One of a set of independent ITK-6 compatibility PRs.