Add unit tests to increase coverage and fix race condition in GameServersQueue

[Copilot]

53 new unit tests across 5 packages, targeting the largest coverage gaps.

cmd/nodeagent — 22 tests (new file: nodeagentmanager_unit_test.go)

• heartbeatHandler: non-existent GS, logEveryHeartbeat, ignoreHealthFromHeartbeat, Active/StandingBy operation responses
• updateHealthAndStateIfNeeded: no-op on unchanged state, valid/invalid transitions, crash recovery (empty→Active)
• updateConnectedPlayersIfNeeded: skip when not Active, skip when count unchanged, count changes, zero players
• gameServerCreatedOrUpdated: new server added to map, non-Active skip, Active+Healthy session details propagation
• gameServerDeleted: map removal, no-op for missing server, DeletedFinalStateUnknown handling
• HeartbeatTimeChecker: recent heartbeat no-mark, already-unhealthy no-mark, no double-mark

cmd/initcontainer — 5 tests

• createGsdkFolders (create + idempotent), multi-port parsing, nested path failure, GsdkConfig JSON key validation

cmd/latencyserver — 3 test specs

• createServer with port 0, getResponse edge cases via DescribeTable, serverLoop end-to-end

cmd/standby-forecaster — 5 tests

• Decreasing regression prediction, increasing forecast series, K8s config loading, metric conversion config, flag overrides

pkg/operator/controllers — 18 tests

• IsNodeReadyAndSchedulable: ready, unschedulable, no condition, Ready=False, multiple conditions
• randString: length and character set
• getValueByState: all state→int mappings
• ByState: sort ordering verification
• NewPodForGameServer: Linux, Windows, label/annotation preservation
• NewGameServerForGameServerBuild: labels, ownerRef, hostPort assignment

Bug fix: race condition in GameServersQueue.PushToQueue

Fixed a pre-existing race condition in PushToQueue that caused the "should work with multiple simultaneous requests" test to be flaky. The old code used a read-lock to check if a build's queue existed, released it, then acquired a write-lock — a concurrent PopFromQueue could delete the build entry in between, causing items to be lost. Fixed by holding a single write-lock for the entire operation.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Dimitris Gkanatsios (dgkanatsios)]

Copilot unit tests failed

[Copilot]

Copilot unit tests failed

The failing test (gameserverqueue tests - should work with multiple simultaneous requests) was caused by a pre-existing race condition in GameServersQueue.PushToQueue, not by the new unit tests. The old code used a read-lock to check build existence, released it, then acquired a write-lock — a concurrent PopFromQueue could delete the build entry in between, causing items to be lost.

Fixed in 569f8cd by holding a single write-lock for the entire PushToQueue operation.