Fixes IOHIDEvent/UITouch phase mismatch that causes some games - #223
Merged
Conversation
- Rebuild IOHIDEvent in setPhaseAndUpdateTimestamp: so eventMask stays in sync with UITouch.phase (was only set on touch creation) - Fix kif_IOHIDEventWithTouches eventMask for ended/cancelled phases - Use per-finger timestamps for more realistic HID events Some games validate that IOHIDEvent properties match the current UITouch phase. Without this fix, moved/ended touches carry a stale began-phase IOHIDEvent, triggering detection.
Member
|
Can the comments for |
Contributor
Author
|
@TheMoonThatRises Thanks for your comments, fix already. |
Contributor
Author
|
@TheMoonThatRises Both comments are addressed now. Could you take another look? Thanks! |
TheMoonThatRises
self-requested a review
June 28, 2026 05:59
TheMoonThatRises
approved these changes
Aug 12, 2026
JoseMoreville
approved these changes
Aug 12, 2026
JoseMoreville
left a comment
JoseMoreville
left a comment
Member
There was a problem hiding this comment.
Seems fine, just a better logic behind. This potentially solves some game issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some games validate that IOHIDEvent properties match the current UITouch phase. Without this fix, moved/ended touches carry a stale began-phase IOHIDEvent, triggering detection.