Fix reply template echoed with unfilled placeholders - #17
Merged
Conversation
BankrBot printed the default reply template's <token> placeholders literally (est p, conv n/100, +xpts, [URL]) instead of real values. Replace the <token> template with a filled example and add an explicit rule: never output a literal placeholder; if a price wasn't fetched, print the real market URL + "verify live". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017xa6j3HGPqC43aEXX4wgZD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live output showed BankrBot printing the default reply template's
<token>placeholders literally —est p,conv n/100,+xpts,+y%,[URL]— instead of substituting real values.Fix in
SKILL.md: replaced the<token>template with a filled example (real illustrative numbers) and added an explicit rule — never output a literal placeholder; if a price wasn't fetched, print the real market URL + "verify live" (not the text "[URL]").The separate analysis-vs-sizing behavior (from PR #16) worked correctly; this only fixes the placeholder rendering.
Verification
./scripts/validate.sh→ all pass.markdown-link-check→ no dead links.🤖 Generated with Claude Code
Generated by Claude Code