Skip to content

Implement core::fmt::Display for ParseError #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Peternator7 merged 2 commits into from
Feb 22, 2026
Merged

Implement core::fmt::Display for ParseError #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b989d8c
Display exists in core
Feb 22, 2026
ee50774
Merge remote-tracking branch 'origin' into peternator7/parse-error-core
Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions strum/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ pub enum ParseError {
VariantNotFound,
}

#[cfg(feature = "std")]
impl std::fmt::Display for ParseError {
fn fmt(&self, f: &mut std::fmt::Formatter) -> Result<(), std::fmt::Error> {
impl core::fmt::Display for ParseError {
fn fmt(&self, f: &mut core::fmt::Formatter) -> Result<(), core::fmt::Error> {
// We could use our macro here, but this way we don't take a dependency on the
// macros crate.
match self {
Expand Down