Repository navigation
Added a launch option to bypass SSL verification on downloads - #9017
Merged
Merged
Conversation
Contributor
|
Hi, please ensure all lines are TAB indented. 😀 |
Contributor
Author
|
Indentation fixed. |
Wires77
requested changes
Oct 24, 2025
| return responseHeader, responseBody, errMsg | ||
| ]] | ||
| local id = LaunchSubScript(script, "", "ConPrintf", url, params.header, params.body, self.connectionProtocol, self.proxyURL) | ||
| local id = LaunchSubScript(script, "", "ConPrintf", url, params.header, params.body, self.connectionProtocol, self.proxyURL, self.noSSL or false) |
Member
There was a problem hiding this comment.
I don't think this is doing what you intend. Passing this as another parameter passes it to the script variable, which is only looking for these parameters (line 255): local url, requestHeader, requestBody, connectionProtocol, proxyURL = ...
You'd want this change in launch:CheckForUpdate as well. Presumably, if SSL doesn't work on the update, it's not going to work for any other page, so we should put the option everywhere.
Wires77
changed the title
Changed the wrong line of code
Wires77
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Steps taken to verify a working solution: