Allow alternative names with commas - #1465
Open
d-buchmann wants to merge 1 commit into
Open
Conversation
Simply replace the commas read from the info provider with wildcards, so they'll match any placeholder character the user chose in the alternative name definition. Fixes Part-DB#1349
d-buchmann
force-pushed
the
alternative_names_containing_commas
branch
from
July 28, 2026 11:44
37e34af to
c79986f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1465 +/- ##
============================================
- Coverage 59.18% 59.16% -0.03%
Complexity 8814 8814
============================================
Files 656 656
Lines 28566 28566
============================================
- Hits 16908 16902 -6
- Misses 11658 11664 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply replace the commas read from the info provider with wildcards, so they'll match any placeholder character the user chose in the alternative name definition.
Fixes #1349