Skip to content

fixed - #98

Merged
BigDella merged 1 commit into
Parcel-Protocol:mainfrom
Akatenvictor:feat/network-profile-fixtures
Sep 26, 2026
Merged

BigDella merged 1 commit into
Parcel-Protocol:mainfrom
Akatenvictor:feat/network-profile-fixtures

Conversation

@Akatenvictor

Copy link
Copy Markdown
Contributor

Summary

Describe what changed and why. One pull request must implement exactly one
issue and one independent feature slice.

Scope proof

Issue: Closes #

Closes #24
Closes #18
Closes #95
Closes #94

Feature directory: features/<slug>/

Changed file count:

git diff --name-only origin/main...HEAD | wc -l
  • This pull request changes at least 20 meaningful files (the scaffold normally creates 23)
  • Every product change is inside the feature directory above
  • This work does not require another open issue or unmerged pull request
  • No generated registry file or shared navigation/route list was edited

How to Test

Describe the exact happy path, one validation failure, one transport failure,
and the network(s) a reviewer should use.

  1. Go to ...
  2. Enter ...
  3. See ...

Evidence

Add screenshots for idle, loading, success and error states. Include the result
of the slice-specific contract check:

npm run verify:features -- <slug>

Checklist

  • npm run check passes locally
  • Logic returns Result<T, Code> for every expected failure
  • Every error code has actionable copy in copy.ts
  • Idle, loading, success and error states are implemented
  • Network requests are tested through MSW, not internal-module mocks
  • Accessibility tests cover at least two states with zero WCAG 2.1 A/AA violations
  • Amount arithmetic uses strings/BigInt, never floating point
  • No secret key is accepted, rendered, stored, logged or transmitted
  • README.md records the feature's non-obvious technical decision

Follow-Up

Call out known limitations only. Do not make this pull request depend on future
work; anything required by the acceptance criteria belongs in this slice.

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@BigDella
BigDella merged commit 9352857 into Parcel-Protocol:main Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants