Repository navigation
Improve build number on releases action - #14354
Closed
kacimiamine wants to merge 1 commit into
Closed
kacimiamine wants to merge 1 commit into
kacimiamine wants to merge 1 commit into
Conversation
Member
|
Thanks, but we considered this and several other alternatives before settling on the current implementation. This breaks several of the guarantees the current setup provides, especially around build races and retries/reruns. We will look into the skipped build numbers. We do not cancel in-progress overlapping builds, but it seems that multiple builds queued at once only runs the last. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I saw build 153 released and the next one was 156, I went to fixing the build number logic. What I did is:
gradle.properties.I tested it on bash since I can't really test the workflow, but the commands work as intended (tested with 26.3, 26.2 and 26.4 that doesn't exist so I can see it returns 0).
Also moved the step down since it needs checkout first to read the
gradle.propertiesfile.