Add Cooking and Brewing Fuel Item Components - #14247
Open
MiniDigger wants to merge 3 commits into
Open
Conversation
MiniDigger
force-pushed
the
feat/fuel-data-components
branch
5 times, most recently
from
September 12, 2026 13:44
a7538dc to
e5d40d1
Compare
MiniDigger
force-pushed
the
feat/fuel-data-components
branch
from
September 12, 2026 13:45
e5d40d1 to
86d0b97
Compare
MiniDigger
marked this pull request as ready for review
September 12, 2026 13:47
- Remove reduntant annotations from components - Move annotations to package-info.java (and create missing) - Add NullMarked where missing - Remove convenience methods for ResolvableFloat/Int and improvement the pattern match - Move the logic for lootcontext to a proper Craft Class (mostly for visual... this is going to be changed when #12778) and a few changes because I don't like yellow marks...
- Add missing Javadocs for ResolvableFloat and ResolvableInt - Remove ignored components because they are implemented now
Doc94
approved these changes
Sep 12, 2026
Doc94
left a comment
Member
There was a problem hiding this comment.
Still missing the reference Resolvable but that can be handle later for any when wanna touch Composter :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.